Sign upLogin

idealo/php-rdkafka-ffi

View on GitHub
Star

Showing 61 of 61 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace RdKafka\FFI;
Severity: Minor
Found in src/RdKafka/FFI/RebalanceCallbackProxy.php and 1 other location - About 55 mins to fix
src/RdKafka/FFI/OffsetCommitCallbackProxy.php on lines 1..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace RdKafka\FFI;
Severity: Minor
Found in src/RdKafka/FFI/OffsetCommitCallbackProxy.php and 1 other location - About 55 mins to fix
src/RdKafka/FFI/RebalanceCallbackProxy.php on lines 1..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method producev has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        int $partition,
        int $msgflags,
        ?string $payload = null,
        ?string $key = null,
        ?array $headers = null,
Severity: Major
Found in src/RdKafka/ProducerTopic.php - About 50 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function commitAsync($message_or_offsets = null): void
    {
        try {
            $topicPartitionList = $this->createTopicPartitionList($message_or_offsets);
        } catch (TypeError $exception) {
    Severity: Minor
    Found in src/RdKafka/KafkaConsumer.php and 1 other location - About 45 mins to fix
    src/RdKafka/KafkaConsumer.php on lines 105..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function commit($message_or_offsets = null): void
    {
        try {
            $topicPartitionList = $this->createTopicPartitionList($message_or_offsets);
        } catch (TypeError $exception) {
    Severity: Minor
    Found in src/RdKafka/KafkaConsumer.php and 1 other location - About 45 mins to fix
    src/RdKafka/KafkaConsumer.php on lines 130..148

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct(CData $nativeMessage)
    {
        $timestampType = Library::new('rd_kafka_timestamp_type_t');
        $this->timestamp = (int) Library::rd_kafka_message_timestamp($nativeMessage, FFI::addr($timestampType));
        $this->timestampType = (int) $timestampType->cdata;
    Severity: Minor
    Found in src/RdKafka/Message.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string $message,
        int $code,
        string $error_string,
        bool $isFatal = false,
        bool $isRetriable = false,
    Severity: Minor
    Found in src/RdKafka/KafkaErrorException.php - About 45 mins to fix

      Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ?CData $topic,
        ?CData $keydata,
        int $keylen,
        int $partition_cnt,
        ?CData $topic_opaque = null,
      Severity: Minor
      Found in src/RdKafka/FFI/NativePartitionerCallbackProxy.php - About 45 mins to fix

        Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                ?CData $topic,
        ?CData $keydata,
        int $keylen,
        int $partition_cnt,
        ?CData $topic_opaque = null,
        Severity: Minor
        Found in src/RdKafka/FFI/PartitionerCallbackProxy.php - About 45 mins to fix

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function __construct(int $id, int $err, int $leader, Collection $replicas, Collection $isrs)
          Severity: Minor
          Found in src/RdKafka/Metadata/Partition.php - About 35 mins to fix

            Method queryWatermarkOffsets has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function queryWatermarkOffsets(string $topic, int $partition, int &$low, int &$high, int $timeout_ms): void
            Severity: Minor
            Found in src/RdKafka.php - About 35 mins to fix

              Method produce has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function produce(int $partition, int $msgflags, ?string $payload = null, ?string $key = null, $opaque = null): void
              Severity: Minor
              Found in src/RdKafka/ProducerTopic.php - About 35 mins to fix

                Function loadSupportedVersions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function loadSupportedVersions(): array
    {
        echo 'Load librdkafka releases ...';

        $content = file_get_contents(
                Severity: Minor
                Found in resources/ffigen/LibrdkafkaHeaderFiles.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                        return $content;
                Severity: Major
                Found in resources/ffigen/LibrdkafkaHeaderFiles.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return '';
                  Severity: Major
                  Found in resources/ffigen/LibrdkafkaHeaderFiles.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return '//' . $matches[1];
                    Severity: Major
                    Found in resources/ffigen/LibrdkafkaHeaderFiles.php - About 30 mins to fix

                      Function setReplicaAssignment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function setReplicaAssignment(int $new_partition_id, array $broker_ids): void
    {
        if (empty($broker_ids) === true) {
            throw new \InvalidArgumentException('broker_ids array must not be empty');
        }
                      Severity: Minor
                      Found in src/RdKafka/Admin/NewPartitions.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function parse(): void
    {
        $this->version = $this->parseInt16();

        switch ($this->version) {
                      Severity: Minor
                      Found in examples/Protocol/GroupMetadataValueParser.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function setReplicaAssignment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function setReplicaAssignment(int $partition_id, array $broker_ids): void
    {
        if (empty($broker_ids) === true) {
            throw new \InvalidArgumentException('broker_ids array must not be empty');
        }
                      Severity: Minor
                      Found in src/RdKafka/Admin/NewTopic.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function parse(): void
    {
        $this->version = $this->parseInt16();

        switch ($this->version) {
                      Severity: Minor
                      Found in examples/Protocol/OffsetCommitValueParser.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language