ifad/clammit

View on GitHub
forwarder/forwarder.go

Summary

Maintainability
A
1 hr
Test Coverage

Method Forwarder.HandleRequest has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (f *Forwarder) HandleRequest(w http.ResponseWriter, req *http.Request) {
    // Catch panics and return a 500 Internal Server Error
    defer func() {
        if err := recover(); err != nil {
            f.logger.Printf("ERROR %s", err)
Severity: Minor
Found in forwarder/forwarder.go - About 1 hr to fix

    Method Forwarder.HandleRequest has 5 return statements (exceeds 4 allowed).
    Open

    func (f *Forwarder) HandleRequest(w http.ResponseWriter, req *http.Request) {
        // Catch panics and return a 500 Internal Server Error
        defer func() {
            if err := recover(); err != nil {
                f.logger.Printf("ERROR %s", err)
    Severity: Major
    Found in forwarder/forwarder.go - About 35 mins to fix

      if block ends with a return statement, so drop this else and outdent its block
      Open

          } else {
      Severity: Minor
      Found in forwarder/forwarder.go by golint

      comment on exported type Forwarder should be of the form "Forwarder ..." (with optional leading article)
      Open

      /*
      Severity: Minor
      Found in forwarder/forwarder.go by golint

      comment on exported method Forwarder.SetLogger should be of the form "SetLogger ..."
      Open

      /*
      Severity: Minor
      Found in forwarder/forwarder.go by golint

      package comment should be of the form "Package forwarder ..."
      Open

      /*
      Severity: Minor
      Found in forwarder/forwarder.go by golint

      comment on exported function NewForwarder should be of the form "NewForwarder ..."
      Open

      /*
      Severity: Minor
      Found in forwarder/forwarder.go by golint

      package comment should not have leading space
      Open

      /*
      Severity: Minor
      Found in forwarder/forwarder.go by golint

      const applicationUrlHeader should be applicationURLHeader
      Open

      const applicationUrlHeader string = "X-Clammit-Backend"
      Severity: Minor
      Found in forwarder/forwarder.go by golint

      comment on exported type Interceptor should be of the form "Interceptor ..." (with optional leading article)
      Open

      /*
      Severity: Minor
      Found in forwarder/forwarder.go by golint

      comment on exported method Forwarder.HandleRequest should be of the form "HandleRequest ..."
      Open

      /*
      Severity: Minor
      Found in forwarder/forwarder.go by golint

      There are no issues that match your filters.

      Category
      Status