Sign upLogin

ikuseiGmbH/smart-village-app-cms

View on GitHub
Star

Showing 1,158 of 1,254 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  if (this.parentNode) {
    this.arrayPath = _.clone(this.parentNode.arrayPath);
    if (this.parentNode.view && this.parentNode.view.array) {
      this.arrayPath.push(this.childPos);
    }
Severity: Major
Found in lib/jsonform.js and 1 other location - About 2 hrs to fix
lib/jsonform.js on lines 2029..2037

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (subBoundaries.minItems !== -1) {
          if (boundaries.minItems !== -1) {
            boundaries.minItems = Math.max(
              boundaries.minItems,
              subBoundaries.minItems
Severity: Major
Found in lib/jsonform.js and 1 other location - About 2 hrs to fix
lib/jsonform.js on lines 2947..2957

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (subBoundaries.maxItems !== -1) {
          if (boundaries.maxItems !== -1) {
            boundaries.maxItems = Math.min(
              boundaries.maxItems,
              subBoundaries.maxItems
Severity: Major
Found in lib/jsonform.js and 1 other location - About 2 hrs to fix
lib/jsonform.js on lines 2936..2946

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Complex method Importer::WasteCalendar#perform (43.6)
Open

  def perform
    @tour_data.each do |tour_data_line|
      @waste_types.each do |waste_type_key, _waste_type|
        next if @tour_assignment[waste_type_key].blank?
        next if @address_assignment[waste_type_key].blank?
Severity: Minor
Found in app/services/importer/waste_calendar.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Method convert_params_for_graphql has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def convert_params_for_graphql
      # Convert has_many categories
      if @construction_params["categories"].present?
        categories = []
        @construction_params["categories"].each do |_key, category|
Severity: Major
Found in app/controllers/constructions_controller.rb - About 2 hrs to fix

    Function setObjKey has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var setObjKey = function (obj, key, value) {
    var keyparts = key.split('.');

    // Recursive version of setObjKey
    var recSetObjKey = function (obj, keyparts, value) {
    Severity: Major
    Found in lib/jsonform-defaults.js - About 2 hrs to fix

      Method edit_survey_record has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def edit_survey_record
      results = @smart_village.query <<~GRAPHQL
        query {
          surveys(
            ids: [
      Severity: Major
      Found in app/controllers/surveys_controller.rb - About 2 hrs to fix

        Method edit has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def edit
    results = @smart_village.query <<~GRAPHQL
      query {
        genericItem(
          id: #{params[:id]}
        Severity: Major
        Found in app/controllers/deadlines_controller.rb - About 2 hrs to fix

          Method has too many lines. [15/10]
          Open

            def load_filtered_category_list(ids)
    results = @smart_village.query <<~GRAPHQL
      query {
        categories(
          ids: #{ids}
          Severity: Minor
          Found in app/controllers/application_controller.rb by rubocop

          This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

          Assignment Branch Condition size for create is too high. [20.27/15]
          Open

            def create
    query = create_or_update_mutation
    begin
      results = @smart_village.query query
      schedule_push_notifications_queries(results.data.create_generic_item.id)
          Severity: Minor
          Found in app/controllers/deadlines_controller.rb by rubocop

          This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

          Cyclomatic complexity for convert_params_for_graphql is too high. [11/6]
          Open

              def convert_params_for_graphql
      # Convert has_many categories
      if @news_item_params["categories"].present?
        categories = []
        @news_item_params["categories"].each do |_key, category|
          Severity: Minor
          Found in app/controllers/news_items_controller.rb by rubocop

          This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

          An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

          Method has too many lines. [15/10]
          Open

              def new_point_of_interest
      OpenStruct.new(
        addresses: [OpenStruct.new(
          geo_location: OpenStruct.new
        )],
          Severity: Minor
          Found in app/controllers/point_of_interests_controller.rb by rubocop

          This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

          Assignment Branch Condition size for post_request is too high. [20.83/15]
          Open

            def post_request
    url = Addressable::URI.parse(@uri.strip).normalize
    http = Net::HTTP.new(url.host, url.port || 80)

    if @uri.include?("https://")
          Severity: Minor
          Found in app/services/api_request_service.rb by rubocop

          This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

          Assignment Branch Condition size for load_access_tokens is too high. [20.05/15]
          Open

            def load_access_tokens
    auth_server = SmartVillageApi.auth_server_url
    uri = Addressable::URI.parse("#{auth_server}/oauth/token")
    uri.query_values = {
      client_id: client_id,
          Severity: Minor
          Found in app/services/authentication.rb by rubocop

          This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

          Method has too many lines. [15/10]
          Open

            def update_tour_dates
    tour_id = params[:id]
    edit_year = params[:year]
    tour_dates = tour_date_params.select { |_key, value| value == "true" }
          Severity: Minor
          Found in app/controllers/waste_calendar_controller.rb by rubocop

          This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

          Method has too many lines. [15/10]
          Open

            def load_access_tokens
    auth_server = SmartVillageApi.auth_server_url
    uri = Addressable::URI.parse("#{auth_server}/oauth/token")
    uri.query_values = {
      client_id: client_id,
          Severity: Minor
          Found in app/services/authentication.rb by rubocop

          This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

          Method has too many lines. [14/10]
          Open

            def visibility
    @smart_village.query <<~GRAPHQL
      mutation {
        changeVisibility (
          id: #{params[:id]},
          Severity: Minor
          Found in app/controllers/data_provider_controller.rb by rubocop

          This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

          Perceived complexity for convert_params_for_graphql is too high. [11/7]
          Open

              def convert_params_for_graphql
      # Convert has_many categories
      if @news_item_params["categories"].present?
        categories = []
        @news_item_params["categories"].each do |_key, category|
          Severity: Minor
          Found in app/controllers/news_items_controller.rb by rubocop

          This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

          Example:

          def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

          Method has too many lines. [14/10]
          Open

            def index
    results = @smart_village.query <<~GRAPHQL
      query {
        comments: surveyComments(
          surveyId: #{params[:survey_id]}
          Severity: Minor
          Found in app/controllers/survey_comments_controller.rb by rubocop

          This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

          Cyclomatic complexity for create is too high. [10/6]
          Open

            def create
    results = @smart_village.query <<~GRAPHQL
      query {
        publicJsonFile(name: "wasteTypes", version: "1.0.0") {
          content
          Severity: Minor
          Found in app/controllers/waste_calendar_controller.rb by rubocop

          This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

          An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

          Severity
          Category
          Status
          Source
          Language