Sign upLogin

ikuseiGmbH/smart-village-app-cms

View on GitHub
Star

Showing 1,158 of 1,254 total issues

Avoid the use of the case equality operator ===.
Open

      return "/events" if params[:item_type] === "EventRecord"
Severity: Minor
Found in app/controllers/data_provider_controller.rb by rubocop

This cop checks for uses of the case equality operator(===).

Example:

# bad
Array === something
(1..100) === 7
/something/ === some_string

# good
something.is_a?(Array)
(1..100).include?(7)
some_string =~ /something/

Line is too long. [110/100]
Open

                tour_stop["payload"]["time_period_in_days"] = tour_stop["payload"]["time_period_in_days"].to_i
Severity: Minor
Found in app/controllers/tours_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if @tour_params["tour_stops"].present?
Severity: Minor
Found in app/controllers/tours_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Use next to skip iteration.
Open

        if nested_values?(lunch.to_h).include?(true)
Severity: Minor
Found in app/controllers/point_of_interests_controller.rb by rubocop

Use next to skip iteration instead of a condition at the end.

Example: EnforcedStyle: skipmodifierifs (default)

# bad
[1, 2].each do |a|
  if a == 1
    puts a
  end
end

# good
[1, 2].each do |a|
  next unless a == 1
  puts a
end

# good
[1, 2].each do |o|
  puts o unless o == 1
end

Example: EnforcedStyle: always

# With `always` all conditions at the end of an iteration needs to be
# replaced by next - with `skip_modifier_ifs` the modifier if like
# this one are ignored: `[1, 2].each { |a| return 'yes' if a == 1 }`

# bad
[1, 2].each do |o|
  puts o unless o == 1
end

# bad
[1, 2].each do |a|
  if a == 1
    puts a
  end
end

# good
[1, 2].each do |a|
  next unless a == 1
  puts a
end

Missing top-level class documentation comment.
Open

class DashboardController < ApplicationController
Severity: Minor
Found in app/controllers/dashboard_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [123/100]
Open

          media_content["source_url"] = media_content.dig("source_url", "url").present? ? media_content["source_url"] : nil
Severity: Minor
Found in app/controllers/constructions_controller.rb by rubocop

Avoid more than 3 levels of block nesting.
Open

              if scenes.count.positive?
                # add target, mp3, mp4, image, light, quad and spot to the first scene
                # if there is a start date and time period in days, otherwise add them to the last
                # scene in order to have them at the correct place in the object for the mobile app
                scene = scenes.last
Severity: Minor
Found in app/controllers/tours_controller.rb by rubocop

This cop checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Line is too long. [105/100]
Open

          opening_hours << opening_hour if nested_values?(opening_hour.except(:open).to_h).include?(true)
Severity: Minor
Found in app/controllers/point_of_interests_controller.rb by rubocop

Missing top-level class documentation comment.
Open

class EncountersSupportsController < ApplicationController
Severity: Minor
Found in app/controllers/encounters_supports_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [141/100]
Open

          location["geoLocation"]["longitude"] = location["geo_location"]["longitude"].to_f if location["geo_location"]["longitude"].present?
Severity: Minor
Found in app/controllers/constructions_controller.rb by rubocop

Use the return of the conditional for variable assignment and comparison.
Open

    if results.try(:data).try(:destroy_record).try(:status_code) == 200
      flash["notice"] = "Eintrag wurde gelöscht"
    else
      flash["notice"] = "Fehler: #{results.errors.inspect}"
    end
Severity: Minor
Found in app/controllers/constructions_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if @push_notifications.present?
Severity: Minor
Found in app/controllers/deadlines_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Line is too long. [102/100]
Open

                if tour_stop["payload"]["mp3"].present? && tour_stop["payload"]["mp3"]["uri"].present?
Severity: Minor
Found in app/controllers/tours_controller.rb by rubocop

Avoid more than 3 levels of block nesting.
Open

                next if scene.blank?
Severity: Minor
Found in app/controllers/tours_controller.rb by rubocop

This cop checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Missing top-level class documentation comment.
Open

class DeadlinesController < ApplicationController
Severity: Minor
Found in app/controllers/deadlines_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

class ApplicationController < ActionController::Base
Severity: Minor
Found in app/controllers/application_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [145/100]
Open

          # => Graphlient::Errors::ClientError (Argument 'open' on InputObject 'OpeningHourInput' has an invalid value. Expected type 'Boolean'.)
Severity: Minor
Found in app/controllers/point_of_interests_controller.rb by rubocop

Missing top-level class documentation comment.
Open

class ConstructionsController < ApplicationController
Severity: Minor
Found in app/controllers/constructions_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [102/100]
Open

                if tour_stop["payload"]["mp4"].present? && tour_stop["payload"]["mp4"]["uri"].present?
Severity: Minor
Found in app/controllers/tours_controller.rb by rubocop

Use the return of the conditional for variable assignment and comparison.
Open

    if results.try(:data).try(:destroy_record).try(:status_code) == 200
      flash["notice"] = "Eintrag wurde gelöscht"
    else
      flash["notice"] = "Fehler: #{results.errors.inspect}"
    end
Severity: Minor
Found in app/controllers/offers_controller.rb by rubocop
Severity
Category
Status
Source
Language