Sign upLogin

ikuseiGmbH/smart-village-app-cms

View on GitHub
Star

Showing 1,158 of 1,254 total issues

Use the return of the conditional for variable assignment and comparison.
Open

    if results.try(:data).try(:destroy_record).try(:status_code) == 200
      flash["notice"] = "Eintrag wurde gelöscht"
    else
      flash["notice"] = "Fehler: #{results.errors.inspect}"
    end
Severity: Minor
Found in app/controllers/news_items_controller.rb by rubocop

Missing top-level class documentation comment.
Open

class NewsItemsController < ApplicationController
Severity: Minor
Found in app/controllers/news_items_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

class SurveyCommentsController < ApplicationController
Severity: Minor
Found in app/controllers/survey_comments_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [108/100]
Open

                if tour_stop["payload"]["target"].present? && tour_stop["payload"]["target"]["uri"].present?
Severity: Minor
Found in app/controllers/tours_controller.rb by rubocop

Use the return of the conditional for variable assignment and comparison.
Open

    if results.try(:data).try(:destroy_record).try(:status_code) == 200
      flash["notice"] = "Eintrag wurde gelöscht"
    else
      flash["notice"] = "Fehler: #{results.errors.inspect}"
    end
Severity: Minor
Found in app/controllers/point_of_interests_controller.rb by rubocop

Move redirect_to encounters_support_path(params[:id]) out of the conditional.
Open

        redirect_to encounters_support_path(params[:id])
Severity: Minor
Found in app/controllers/encounters_supports_controller.rb by rubocop

This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

Example:

# bad
if condition
  do_x
  do_z
else
  do_y
  do_z
end

# good
if condition
  do_x
else
  do_y
end
do_z

# bad
if condition
  do_z
  do_x
else
  do_z
  do_y
end

# good
do_z
if condition
  do_x
else
  do_y
end

# bad
case foo
when 1
  do_x
when 2
  do_x
else
  do_x
end

# good
case foo
when 1
  do_x
  do_y
when 2
  # nothing
else
  do_x
  do_z
end

Missing top-level class documentation comment.
Open

class DataProviderController < ApplicationController
Severity: Minor
Found in app/controllers/data_provider_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [123/100]
Open

          media_content["source_url"] = media_content.dig("source_url", "url").present? ? media_content["source_url"] : nil
Severity: Minor
Found in app/controllers/offers_controller.rb by rubocop

Missing top-level class documentation comment.
Open

class OffersController < ApplicationController
Severity: Minor
Found in app/controllers/offers_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [123/100]
Open

          media_content["source_url"] = media_content.dig("source_url", "url").present? ? media_content["source_url"] : nil
Severity: Minor
Found in app/controllers/deadlines_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

    if helpers.visible_in_role?("role_defect_report")
Severity: Minor
Found in app/controllers/dashboard_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if @construction_params["dates"].present?
Severity: Minor
Found in app/controllers/constructions_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Avoid more than 3 levels of block nesting.
Open

                if scene["downloadable_uris"].present?
                  downloadable_uris = []

                  scene["downloadable_uris"].each do |_key, downloadable_uri|
                    next if downloadable_uri.blank?
Severity: Minor
Found in app/controllers/tours_controller.rb by rubocop

This cop checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Avoid more than 3 levels of block nesting.
Open

              if tour_stop["payload"]["time_period_in_days"].present?
                tour_stop["payload"]["time_period_in_days"] = tour_stop["payload"]["time_period_in_days"].to_i
              end
Severity: Minor
Found in app/controllers/tours_controller.rb by rubocop

This cop checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if @offer_params["operating_company"].present?
Severity: Minor
Found in app/controllers/offers_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Line is too long. [111/100]
Open

        flash[:error] = "Es ist ein Fehler aufgetreten. Bitte erneut versuchen oder neue Support-ID erstellen."
Severity: Minor
Found in app/controllers/encounters_supports_controller.rb by rubocop

Avoid the use of the case equality operator ===.
Open

      return "/surveys/#{params[:parent_id]}/comments" if params[:item_type] === "Survey_Comment"
Severity: Minor
Found in app/controllers/data_provider_controller.rb by rubocop

This cop checks for uses of the case equality operator(===).

Example:

# bad
Array === something
(1..100) === 7
/something/ === some_string

# good
something.is_a?(Array)
(1..100).include?(7)
some_string =~ /something/

Missing magic comment # frozen_string_literal: true.
Open

class EncountersSupportsController < ApplicationController
Severity: Minor
Found in app/controllers/encounters_supports_controller.rb by rubocop

This cop is designed to help upgrade to after Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default after Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: always (default)

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Missing top-level class documentation comment.
Open

class DefectReportsController < ApplicationController
Severity: Minor
Found in app/controllers/defect_reports_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if @event_params["organizer"].present?
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok
Severity
Category
Status
Source
Language