Sign upLogin

ikuseiGmbH/smart-village-app-cms

View on GitHub
Star

Showing 1,158 of 1,254 total issues

Line is too long. [121/100]
Open

      @survey_params["question_allow_multiple_responses"] = @survey_params["question_allow_multiple_responses"] == "true"
Severity: Minor
Found in app/controllers/surveys_controller.rb by rubocop

Missing top-level class documentation comment.
Open

class SurveysController < ApplicationController
Severity: Minor
Found in app/controllers/surveys_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

  class Base
Severity: Minor
Found in app/services/converter/base.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

class Authentication
Severity: Minor
Found in app/services/authentication.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Open

  layout 'mailer'
Severity: Minor
Found in app/mailers/application_mailer.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

!important should not be used
Open

  font-family: 'Titillium Web', sans-serif !important;
Severity: Minor
Found in app/assets/stylesheets/custom.css by scss-lint

Color literals like #2d963c should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  background-color: #2d963c;
Severity: Minor
Found in app/assets/stylesheets/custom.css by scss-lint

Avoid using id selectors
Open

body #wrapper #content-wrapper {
Severity: Minor
Found in app/assets/stylesheets/custom.css by scss-lint

Line is too long. [114/100]
Open

    # TODO: temporarily commented, as we need memcached for this in order to be successful across multiple workers
Severity: Minor
Found in app/controllers/waste_calendar_controller.rb by rubocop

Missing top-level class documentation comment.
Open

class ApplicationMailer < ActionMailer::Base
Severity: Minor
Found in app/mailers/application_mailer.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing magic comment # frozen_string_literal: true.
Open

require 'test_helper'
Severity: Minor
Found in test/controllers/session_controller_test.rb by rubocop

This cop is designed to help upgrade to after Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default after Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: always (default)

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Line is too long. [114/100]
Open

    # TODO: temporarily commented, as we need memcached for this in order to be successful across multiple workers
Severity: Minor
Found in app/controllers/waste_calendar_controller.rb by rubocop

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Open

require 'test_helper'
Severity: Minor
Found in test/controllers/events_controller_test.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Color literals like #085036 should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  background-image: linear-gradient(180deg, #2d963c 10%, #085036 100%);
Severity: Minor
Found in app/assets/stylesheets/custom.css by scss-lint

Avoid using id selectors
Open

  #sidebarToggleTop.toggled {
Severity: Minor
Found in app/assets/stylesheets/custom.css by scss-lint

Use the return of the conditional for variable assignment and comparison.
Open

    if results.try(:data).try(:destroy_record).try(:status_code) == 200
      flash["notice"] = "Eintrag wurde gelöscht"
    else
      flash["notice"] = "Fehler: #{results.errors.inspect}"
    end
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Line is too long. [105/100]
Open

        query = Converter::Base.new.build_mutation("assignWasteLocationToTour", waste_tour_matrix, false)
Severity: Minor
Found in app/controllers/waste_calendar_controller.rb by rubocop

Useless assignment to variable - results.
Open

      results = @smart_village.query query
Severity: Minor
Found in app/controllers/push_notifications_controller.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Missing top-level class documentation comment.
Open

class Importer::WasteCalendar
Severity: Minor
Found in app/services/importer/waste_calendar.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [116/100]
Open

    if Gem::Version.correct?(bundler_version) && Gem::Version.new(bundler_version).release < Gem::Version.new("2.0")
Severity: Minor
Found in bin/bundle by rubocop
Severity
Category
Status
Source
Language