Showing 251 of 326 total issues
File StatsPageViewModel.cs
has 601 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using System.Threading.Tasks;
File TodayPageViewModel.cs
has 559 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Linq;
using System.Net.Http;
Method startRegister
has a Cognitive Complexity of 73 (exceeds 20 allowed). Consider refactoring. Open
public async Task<Task<object>> startRegister()
{
try
{
if (checkCredentials())
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File SaveMarksPageViewModel.cs
has 438 lines of code (exceeds 250 allowed). Consider refactoring. Open
using EduCATS.Helpers.Forms;
using EduCATS.Helpers.Json;
using EduCATS.Networking;
using EduCATS.Networking.AppServices;
using EduCATS.Networking.Models.SaveMarks;
File StatsResultsPageViewModel.cs
has 432 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using System.Threading.Tasks;
File TestPassingPageViewModel.cs
has 400 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using EduCATS.Data;
Class AppServices
has 37 methods (exceeds 20 allowed). Consider refactoring. Open
public static partial class AppServices
{
/// <summary>
/// Authorize request.
/// </summary>
Class DataAccess
has 37 methods (exceeds 20 allowed). Consider refactoring. Open
public static partial class DataAccess
{
/// <summary>
/// Login callback.
/// </summary>
File RegistrationPageViewModel.cs
has 366 lines of code (exceeds 250 allowed). Consider refactoring. Open
using EduCATS.Data.Models;
using EduCATS.Data.Models.Registration;
using EduCATS.Helpers.Forms;
using EduCATS.Helpers.Json;
using EduCATS.Helpers.Logs;
File LoginPageView.cs
has 366 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using EduCATS.Themes;
using EduCATS.Pages.Login.ViewModels;
using FFImageLoading.Forms;
using Nyxbull.Plugins.CrossLocalization;
Method startRegister
has 107 lines of code (exceeds 25 allowed). Consider refactoring. Open
public async Task<Task<object>> startRegister()
{
try
{
if (checkCredentials())
File RegistrationPageView.cs
has 325 lines of code (exceeds 250 allowed). Consider refactoring. Open
using EduCATS.Data;
using EduCATS.Data.Models;
using EduCATS.Helpers.Forms;
using EduCATS.Helpers.Forms.Styles;
using EduCATS.Pages.Registration.ViewModels;
Method saveMarks
has 93 lines of code (exceeds 25 allowed). Consider refactoring. Open
private async Task<KeyValuePair<string, HttpStatusCode>> saveMarks()
{
string link = "";
string body = "";
if (_titleOfPage == CrossLocalization.Translate("stats_page_lectures_visiting"))
Class AppPages
has 30 methods (exceeds 20 allowed). Consider refactoring. Open
public class AppPages : IPages
{
/// <summary>
/// Property for getting and setting <see cref="Application.Current.MainPage"/>.
/// </summary>
Method startResetPassword
has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring. Open
protected async Task<object> startResetPassword()
{
try
{
if (checkCredentials())
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method createView
has 83 lines of code (exceeds 25 allowed). Consider refactoring. Open
void createView()
{
var group = new Label
{
TextColor = Color.FromHex(Theme.Current.StatisticsDetailsTitleColor),
Class IPages
has 27 methods (exceeds 20 allowed). Consider refactoring. Open
public interface IPages
{
/// <summary>
/// Close page.
/// </summary>
Method getAndSetStatistics
has 77 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected virtual async Task getAndSetStatistics()
{
try
{
if (CurrentSubject != null)
Consider simplifying this complex logical expression. Open
if (!(
((nameOfUser[i] >= 'a') && (nameOfUser[i] <= 'z')) || ((nameOfUser[i] >= 'A') && (nameOfUser[i] <= 'Z')) ||
((nameOfUser[i] >= 'а') && (nameOfUser[i] <= 'я')) || ((nameOfUser[i] >= 'А') && (nameOfUser[i] <= 'Я')) ||
((nameOfUser[i] == '_') || (nameOfUser[i] == ' ') || (nameOfUser[i] == '-')) ||
(nameOfUser[i] >= '0' && nameOfUser[i] <= '9')))
Similar blocks of code found in 3 locations. Consider refactoring. Open
{
practiceVisitingList = stat as LabsVisitingList;
_takedLabs = new TakedLabs();
WebRequest request = WebRequest.Create(Links.GetPracticialsTest + "subjectId=" + subjectId + "&groupId=" + groupId);
request.Headers.Add("Authorization", _services.Preferences.AccessToken);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 209.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76