Sign upLogin

ilyalehchylin/educats-xamarin

View on GitHub
Star

Showing 251 of 326 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            {
                labsVisitingList = stat as LabsVisitingList;
                _takedLabs = new TakedLabs();
                WebRequest request = WebRequest.Create(Links.GetLabsTest + "subjectId=" + _subjectId + "&groupId=" + groupId);
                request.Headers.Add("Authorization", _services.Preferences.AccessToken);
Severity: Major
Found in source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs and 2 other locations - About 3 hrs to fix
source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs on lines 38..58
source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs on lines 60..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 209.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            {
                labsVisitingList = stat as LabsVisitingList;
                _takedLabs = new TakedLabs();
                WebRequest request = WebRequest.Create(Links.GetLabsTest + "subjectId=" + subjectId + "&groupId=" + groupId);
                request.Headers.Add("Authorization", _services.Preferences.AccessToken);
Severity: Major
Found in source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs and 2 other locations - About 3 hrs to fix
source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs on lines 38..58
source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs on lines 60..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 209.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method startResetPassword has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        protected async Task<object> startResetPassword()
        { 
            try
            {
                if (checkCredentials())
Severity: Major
Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs - About 2 hrs to fix

    Method saveMarks has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
    Open

            private async Task<KeyValuePair<string, HttpStatusCode>> saveMarks()
        {
            string link = "";
            string body = "";
            if (_titleOfPage == CrossLocalization.Translate("stats_page_lectures_visiting"))
    Severity: Minor
    Found in source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            private async Task<object> requestDataAsync(string link, HttpContent _postContent)
        {
            var client = new HttpClient();
            client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue(services.Preferences.AccessToken);
            if (_title == CrossLocalization.Translate("practice_mark"))
    Severity: Major
    Found in source/EduCATS/Pages/SaveLabsAndPracticeMarks/ViewModels/SavePracticeAndLabsPageView.cs and 1 other location - About 2 hrs to fix
    source/EduCATS/Pages/SaveMarks/Views/SaveMarksPageView.cs on lines 74..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 186.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            private async Task<object> requestDataAsync(string link, HttpContent _postContent)
        {
            var client = new HttpClient();
            client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue(services.Preferences.AccessToken);
            if (_title == CrossLocalization.Translate("practiсe_visiting"))
    Severity: Major
    Found in source/EduCATS/Pages/SaveMarks/Views/SaveMarksPageView.cs and 1 other location - About 2 hrs to fix
    source/EduCATS/Pages/SaveLabsAndPracticeMarks/ViewModels/SavePracticeAndLabsPageView.cs on lines 117..133

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 186.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File DataAccess.cs has 275 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    using System.Collections.Generic;
using System.Net;
using System.Threading.Tasks;
using EduCATS.Constants;
using EduCATS.Data.Models;
    Severity: Minor
    Found in source/EduCATS/Data/DataAccess.cs - About 2 hrs to fix

      File LoginPageViewModel.cs has 273 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      using System;
using System.Threading.Tasks;
using EduCATS.Data;
using EduCATS.Data.Models;
using EduCATS.Data.User;
      Severity: Minor
      Found in source/EduCATS/Pages/Login/ViewModels/LoginPageViewModel.cs - About 2 hrs to fix

        Class TodayPageViewModel has 23 methods (exceeds 20 allowed). Consider refactoring.
        Open

            public class TodayPageViewModel : ViewModel
    {
        readonly IPlatformServices _services;

        readonly double _subjectHeight;
        Severity: Minor
        Found in source/EduCATS/Pages/Today/Base/ViewModels/TodayPageViewModel.cs - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  public bool LatinPassword()
        {
            bool latin_password = true;
            try
            {
          Severity: Major
          Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs and 1 other location - About 2 hrs to fix
          source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs on lines 88..108

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 177.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  public bool LatinPassword()
        {
            bool latin_password = true;
            try
            {
          Severity: Major
          Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs and 1 other location - About 2 hrs to fix
          source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs on lines 91..112

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 177.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method calculateChartData has 59 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  List<double> calculateChartData(StatsStudentModel stats, LabsVisitingList studentsPractStatistics, LabsVisitingList studentTestStatistics, LaboratoryWorksModel currentPractStudentStatistics, LaboratoryWorksModel worksModel)
        {
            double avgLabs = 0;
            double avgTests = 0;
            double avgPract = 0;
          Severity: Major
          Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 2 hrs to fix

            Method setLabsVisiting has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    void setLabsVisiting(StatsStudentModel student, LaboratoryWorksModel labs)
        {
            if (_statisticsPage == StatsPageEnum.LabsVisiting)
            {
                if (Servers.Current == Servers.EduCatsAddress)
            Severity: Major
            Found in source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs - About 2 hrs to fix

              Class TestPassingPageViewModel has 21 methods (exceeds 20 allowed). Consider refactoring.
              Open

                  public partial class TestPassingPageViewModel : ViewModel
    {
        readonly IPlatformServices _services;
        readonly DateTime _startedEntireTest;
        readonly int _testId;
              Severity: Minor
              Found in source/EduCATS/Pages/Testing/Passing/ViewModels/TestPassingPageViewModel.cs - About 2 hrs to fix

                Method getFiles has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        async Task getFiles()
        {
            IEnumerable<FilesPageModel> files = null;

            var appDataDirectory = PlatformServices.Device.GetAppDataDirectory();
                Severity: Major
                Found in source/EduCATS/Pages/Files/ViewModels/FilesPageViewModel.cs - About 2 hrs to fix

                  File ForgotPasswordPageView.cs has 254 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  using EduCATS.Helpers.Forms;
using EduCATS.Helpers.Forms.Styles;
using EduCATS.Pages.ForgotPassword.ViewModels;
using EduCATS.Themes;
using FFImageLoading.Forms;
                  Severity: Minor
                  Found in source/EduCATS/Pages/ForgotPassword/Views/ForgotPasswordPageView.cs - About 2 hrs to fix

                    Method setChartData has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
                    Open

                            void setChartData(StatsStudentModel stats, LabsVisitingList studentsPractStatistics, LabsVisitingList studentTestStatistics, List<double> averages = null)
        {
            try {
                double rating = 0;
                    Severity: Minor
                    Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method saveMarks has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            private async Task saveMarks()
        {
            string body = ""; 
            string link = "";
            if (_title == CrossLocalization.Translate("practice_mark"))
                    Severity: Major
                    Found in source/EduCATS/Pages/SaveLabsAndPracticeMarks/ViewModels/SaveSingleStudentMarkPageViewModel.cs - About 2 hrs to fix

                      File ForgotPasswordPageViewModel.cs has 252 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      using EduCATS.Helpers.Forms;
using EduCATS.Helpers.Json;
using EduCATS.Helpers.Logs;
using EduCATS.Networking;
using EduCATS.Networking.AppServices;
                      Severity: Minor
                      Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs - About 2 hrs to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                SearchBar createSearchBar()
        {
            var searchBar = new SearchBar
            {
                Margin = _searchBarMargin,
                        Severity: Major
                        Found in source/EduCATS/Pages/Statistics/Students/Views/StudentsPageView.cs and 1 other location - About 2 hrs to fix
                        source/EduCATS/Pages/Parental/Statistics/StudentListPage/Views/ParentalStudentPsageView.cs on lines 55..70

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 152.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language