ilyalehchylin/educats-xamarin

View on GitHub
source/EduCATS/Pages/Files/ViewModels/FilesPageViewModel.cs

Summary

Maintainability
C
1 day
Test Coverage

Method getFiles has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        async Task getFiles()
        {
            IEnumerable<FilesPageModel> files = null;

            var appDataDirectory = PlatformServices.Device.GetAppDataDirectory();
Severity: Major
Found in source/EduCATS/Pages/Files/ViewModels/FilesPageViewModel.cs - About 2 hrs to fix

    File FilesPageViewModel.cs has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    using System;
    using System.Collections.Generic;
    using System.ComponentModel;
    using System.IO;
    using System.Linq;
    Severity: Minor
    Found in source/EduCATS/Pages/Files/ViewModels/FilesPageViewModel.cs - About 2 hrs to fix

      Method openFile has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              void openFile(object selectedObject)
              {
                  try {
                      if (AppDemo.Instance.IsDemoAccount) {
                          PlatformServices.Device.MainThread(
      Severity: Minor
      Found in source/EduCATS/Pages/Files/ViewModels/FilesPageViewModel.cs - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        files = filesModel.Files?.Select(f =>
                        {
                            var file = Path.Combine(appDataDirectory, f.Name);
                            var exists = File.Exists(file);
                            return new FilesPageModel(f, exists);
        Severity: Minor
        Found in source/EduCATS/Pages/Files/ViewModels/FilesPageViewModel.cs and 1 other location - About 55 mins to fix
        source/EduCATS/Pages/Files/ViewModels/FilesPageViewModel.cs on lines 148..153

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 84.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        files = filesModel.Lectures?.Select(f =>
                        {
                            var file = Path.Combine(appDataDirectory, f.Name);
                            var exists = File.Exists(file);
                            return new FilesPageModel(f, exists);
        Severity: Minor
        Found in source/EduCATS/Pages/Files/ViewModels/FilesPageViewModel.cs and 1 other location - About 55 mins to fix
        source/EduCATS/Pages/Files/ViewModels/FilesPageViewModel.cs on lines 169..174

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 84.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                async Task update(bool dialog)
                {
                    if (dialog) {
                        PlatformServices.Dialogs.ShowLoading();
                    } else {
        Severity: Minor
        Found in source/EduCATS/Pages/Files/ViewModels/FilesPageViewModel.cs and 1 other location - About 40 mins to fix
        source/EduCATS/Pages/Recommendations/ViewModels/RecommendationsPageViewModel.cs on lines 60..75

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status