Sign upLogin

ilyalehchylin/educats-xamarin

View on GitHub
Star
source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs

Summary

Maintainability
D
2 days
Test Coverage

Method startResetPassword has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
Open

        protected async Task<object> startResetPassword()
        { 
            try
            {
                if (checkCredentials())
Severity: Minor
Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method startResetPassword has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        protected async Task<object> startResetPassword()
        { 
            try
            {
                if (checkCredentials())
Severity: Major
Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs - About 2 hrs to fix

    File ForgotPasswordPageViewModel.cs has 252 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    using EduCATS.Helpers.Forms;
using EduCATS.Helpers.Json;
using EduCATS.Helpers.Logs;
using EduCATS.Networking;
using EduCATS.Networking.AppServices;
    Severity: Minor
    Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

                          if (!(((NewPassword[i] >= 'a') && (NewPassword[i] <= 'z')) || ((NewPassword[i] >= 'A') && (NewPassword[i] <= 'Z')) || (NewPassword[i] == '_') ||
                        ((NewPassword[i] >= '0') && NewPassword[i] <= '9')))
                    {
                        latin_password = false;
                        break;
      Severity: Major
      Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                    return Task.FromResult<object>(null);
        Severity: Major
        Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return Task.FromResult<object>(null);
          Severity: Major
          Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return Task.FromResult<object>(null);
            Severity: Major
            Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      public bool LatinPassword()
        {
            bool latin_password = true;
            try
            {
              Severity: Major
              Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs and 1 other location - About 2 hrs to fix
              source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs on lines 91..112

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 177.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (QuestionId == CrossLocalization.Translate("mother_last_name"))
                    {
                        SelectedQuestionId = 1;
                    }
              Severity: Minor
              Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs and 1 other location - About 45 mins to fix
              source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs on lines 184..195

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 76.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (!(uppercase != 0 && latin_password == true))
                    {
                        _services.Dialogs.ShowMessage(CrossLocalization.Translate("password_not_correct"),
                                    CrossLocalization.Translate("latin_password"));
                        return Task.FromResult<object>(null);
              Severity: Minor
              Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs and 1 other location - About 45 mins to fix
              source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs on lines 224..229

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                                  if (JsonConvert.DeserializeObject<string>(result.Key) == "Пользователь не найден!")
                    {
                        _services.Dialogs.ShowError(CrossLocalization.Translate("no_user"));
                        return Task.FromResult<object>(null);
                    }
              Severity: Minor
              Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs and 2 other locations - About 40 mins to fix
              source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs on lines 159..163
              source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs on lines 198..202

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 68.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                                  if (JsonConvert.DeserializeObject<string>(result.Key) == "Введен неверный секретный ответ")
                    {
                        _services.Dialogs.ShowError(CrossLocalization.Translate("invaild_answer"));
                        return Task.FromResult<object>(null);
                    }
              Severity: Minor
              Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs and 2 other locations - About 40 mins to fix
              source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs on lines 153..157
              source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs on lines 198..202

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 68.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (!(NewPassword.Length > 6 && NewPassword.Length < 30))
                    {
                        _services.Dialogs.ShowError(CrossLocalization.Translate("password_length_error"));
                        return Task.FromResult<object>(null);
                    }
              Severity: Minor
              Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs and 1 other location - About 35 mins to fix
              source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs on lines 218..222

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 67.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      {
            var newpassword = new ForgotPasswordModel
            {
                Password = newPassword,
                UserName = userName,
              Severity: Minor
              Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs and 1 other location - About 35 mins to fix
              source/EduCATS/Networking/AppServices/AppServices.cs on lines 47..56

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (string.IsNullOrEmpty(UserName) ||
                string.IsNullOrEmpty(NewPassword) ||
                string.IsNullOrEmpty(ConfirmPassword) ||
                string.IsNullOrEmpty(AnswerToSecretQuestion) || 
                string.IsNullOrEmpty(QuestionId))
              Severity: Minor
              Found in source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs and 1 other location - About 35 mins to fix
              source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs on lines 66..70

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 63.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status