Sign upLogin

ilyalehchylin/educats-xamarin

View on GitHub
Star
source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs

Summary

Maintainability
F
4 days
Test Coverage

Method startRegister has a Cognitive Complexity of 73 (exceeds 20 allowed). Consider refactoring.
Open

        public async Task<Task<object>> startRegister()
        {
            try
            {
                if (checkCredentials())
Severity: Minor
Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File RegistrationPageViewModel.cs has 366 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using EduCATS.Data.Models;
using EduCATS.Data.Models.Registration;
using EduCATS.Helpers.Forms;
using EduCATS.Helpers.Json;
using EduCATS.Helpers.Logs;
Severity: Minor
Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 4 hrs to fix

    Method startRegister has 107 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public async Task<Task<object>> startRegister()
        {
            try
            {
                if (checkCredentials())
    Severity: Major
    Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 4 hrs to fix

      Consider simplifying this complex logical expression.
      Open

                          if (!(
                        ((nameOfUser[i] >= 'a') && (nameOfUser[i] <= 'z')) || ((nameOfUser[i] >= 'A') && (nameOfUser[i] <= 'Z')) ||
                        ((nameOfUser[i] >= 'а') && (nameOfUser[i] <= 'я')) || ((nameOfUser[i] >= 'А') && (nameOfUser[i] <= 'Я')) ||
                        ((nameOfUser[i] == '_') || (nameOfUser[i] == ' ') || (nameOfUser[i] == '-')) ||
                        (nameOfUser[i] >= '0' && nameOfUser[i] <= '9')))
      Severity: Critical
      Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 3 hrs to fix

        Consider simplifying this complex logical expression.
        Open

                            if (!(((UserName[i] >= 'a') && (UserName[i] <= 'z')) || ((UserName[i] >= 'A') && (UserName[i] <= 'Z'))
                        || ((UserName[i] >= '0') && (UserName[i] <= '9'))
                        || (UserName[i] == '_')
                        || (UserName[i] == '.')
                        || (UserName[i] == '-')
        Severity: Critical
        Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 2 hrs to fix

          Method CheckNameOfUser has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
          Open

                  public bool CheckNameOfUser(string nameOfUser)
        {
            bool name = true;
            try
            {
          Severity: Minor
          Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

                      if (string.IsNullOrEmpty(UserName) ||
                string.IsNullOrEmpty(Password) ||
                string.IsNullOrEmpty(ConfirmPassword) ||
                string.IsNullOrEmpty(Name) ||
                string.IsNullOrEmpty(Surname) ||
          Severity: Critical
          Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 1 hr to fix

            Method RegistrationPostAsync has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    public async Task<KeyValuePair<string, HttpStatusCode>> RegistrationPostAsync(string username, string name, string surname, string patronymic, string password, string confirmPassword,
                        int group, int questionId, string answerToSecretQuestion)
            Severity: Major
            Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                                  if (!(((Password[i] >= 'a') && (Password[i] <= 'z')) || ((Password[i] >= 'A') && (Password[i] <= 'Z')) || (Password[i] == '_') ||
                        ((Password[i] >= '0') && Password[i] <= '9')))
                    {
                        latin_password = false;
                        break;
              Severity: Major
              Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 1 hr to fix

                Avoid too many return statements within this method.
                Open

                            return Task.FromResult<object>(null);
                Severity: Major
                Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                          return Task.FromResult<object>(null);
                  Severity: Major
                  Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                            return Task.FromResult<object>(null);
                    Severity: Major
                    Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                              return Task.FromResult<object>(null);
                      Severity: Major
                      Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                                return Task.FromResult<object>(null);
                        Severity: Major
                        Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                                  return Task.FromResult<object>(null);
                          Severity: Major
                          Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                return Task.FromResult<object>(null);
                            Severity: Major
                            Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                      return Task.FromResult<object>(null);
                              Severity: Major
                              Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs - About 30 mins to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        public bool LatinPassword()
        {
            bool latin_password = true;
            try
            {
                                Severity: Major
                                Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs and 1 other location - About 2 hrs to fix
                                source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs on lines 88..108

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 177.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                                        ((nameOfUser[i] >= 'a') && (nameOfUser[i] <= 'z')) || ((nameOfUser[i] >= 'A') && (nameOfUser[i] <= 'Z')) ||
                        ((nameOfUser[i] >= 'а') && (nameOfUser[i] <= 'я')) || ((nameOfUser[i] >= 'А') && (nameOfUser[i] <= 'Я')) ||
                                Severity: Major
                                Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs and 1 other location - About 1 hr to fix
                                source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs on lines 146..147

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 94.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                                    if (!(((UserName[i] >= 'a') && (UserName[i] <= 'z')) || ((UserName[i] >= 'A') && (UserName[i] <= 'Z'))
                        || ((UserName[i] >= '0') && (UserName[i] <= '9'))
                                Severity: Major
                                Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs and 1 other location - About 1 hr to fix
                                source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs on lines 122..123

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 94.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                                    if (QuestionId == CrossLocalization.Translate("mother_last_name"))
                    {
                        SelectedQuestionId = 1;
                    }
                    else if (QuestionId == CrossLocalization.Translate("pets_name"))
                                Severity: Minor
                                Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs and 1 other location - About 45 mins to fix
                                source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs on lines 132..144

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 76.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                                    if (!(uppercase != 0 && latinPassword == true))
                    {
                        _services.Dialogs.ShowMessage(CrossLocalization.Translate("password_not_correct"),
                                    CrossLocalization.Translate("latin_password"));
                        return Task.FromResult<object>(null);
                                Severity: Minor
                                Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs and 1 other location - About 45 mins to fix
                                source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs on lines 125..130

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 74.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                                    if (JsonConvert.DeserializeObject<string>(userExists.Key) == "true")
                    {
                        _services.Dialogs.ShowError(CrossLocalization.Translate("user_exists"));
                        return Task.FromResult<object>(null);
                    }
                                Severity: Minor
                                Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs and 2 other locations - About 40 mins to fix
                                source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs on lines 153..157
                                source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs on lines 159..163

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 68.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                                    if (!(Password.Length >= 6 && Password.Length <= 30))
                    {
                        _services.Dialogs.ShowError(CrossLocalization.Translate("password_length_error"));
                        return Task.FromResult<object>(null);
                    }
                                Severity: Minor
                                Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs and 1 other location - About 35 mins to fix
                                source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs on lines 119..123

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 67.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                            if (string.IsNullOrEmpty(UserName) ||
                string.IsNullOrEmpty(Password) ||
                string.IsNullOrEmpty(ConfirmPassword) ||
                string.IsNullOrEmpty(Name) ||
                string.IsNullOrEmpty(Surname) ||
                                Severity: Minor
                                Found in source/EduCATS/Pages/Registration/ViewModels/RegistrationPageViewModel.cs and 1 other location - About 35 mins to fix
                                source/EduCATS/Pages/ForgotPassword/ViewModels/ForgotPasswordPageViewModel.cs on lines 66..70

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 63.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status