Sign upLogin

ilyalehchylin/educats-xamarin

View on GitHub
Star
source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs

Summary

Maintainability
C
1 day
Test Coverage

File SavePracticeAndLabsPageViewModel.cs has 251 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using EduCATS.Data.Models;
using EduCATS.Helpers.Forms;
using EduCATS.Helpers.Logs;
using EduCATS.Networking;
using EduCATS.Networking.Models.SaveMarks;
Severity: Minor
Found in source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs - About 2 hrs to fix

    Method createLabsMarksPage has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private void createLabsMarksPage(LabsVisitingList labsVisitingList)
        {
            FullNames = new List<string>();
            LabsVisitingMarks = new List<StudentsPageModel>();
            Date1 = new List<string>();
    Severity: Minor
    Found in source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  {
                practiceVisitingList = stat as LabsVisitingList;
                _takedLabs = new TakedLabs();
                WebRequest request = WebRequest.Create(Links.GetPracticialsTest + "subjectId=" + subjectId + "&groupId=" + groupId);
                request.Headers.Add("Authorization", _services.Preferences.AccessToken);
      Severity: Major
      Found in source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs and 2 other locations - About 3 hrs to fix
      source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs on lines 60..80
      source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs on lines 60..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 209.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  {
                labsVisitingList = stat as LabsVisitingList;
                _takedLabs = new TakedLabs();
                WebRequest request = WebRequest.Create(Links.GetLabsTest + "subjectId=" + subjectId + "&groupId=" + groupId);
                request.Headers.Add("Authorization", _services.Preferences.AccessToken);
      Severity: Major
      Found in source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs and 2 other locations - About 3 hrs to fix
      source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs on lines 38..58
      source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs on lines 60..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 209.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status