Sign upLogin

ilyalehchylin/educats-xamarin

View on GitHub
Star
source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs

Summary

Maintainability
D
2 days
Test Coverage

File SaveMarksPageViewModel.cs has 438 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using EduCATS.Helpers.Forms;
using EduCATS.Helpers.Json;
using EduCATS.Networking;
using EduCATS.Networking.AppServices;
using EduCATS.Networking.Models.SaveMarks;
Severity: Minor
Found in source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs - About 6 hrs to fix

    Method saveMarks has 93 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private async Task<KeyValuePair<string, HttpStatusCode>> saveMarks()
        {
            string link = "";
            string body = "";
            if (_titleOfPage == CrossLocalization.Translate("stats_page_lectures_visiting"))
    Severity: Major
    Found in source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs - About 3 hrs to fix

      Method saveMarks has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
      Open

              private async Task<KeyValuePair<string, HttpStatusCode>> saveMarks()
        {
            string link = "";
            string body = "";
            if (_titleOfPage == CrossLocalization.Translate("stats_page_lectures_visiting"))
      Severity: Minor
      Found in source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method createLecturesVisitingPage has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              void createLecturesVisitingPage(VisitingLecturesList statistics)
        {
            _currentLecturesVisitingMarks = new List<VisitingPageModel>();
            LecturesMarks = new List<VisitingPageModel>();
            Date = new List<string>();
      Severity: Minor
      Found in source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    {
                labsVisitingList = stat as LabsVisitingList;
                _takedLabs = new TakedLabs();
                WebRequest request = WebRequest.Create(Links.GetLabsTest + "subjectId=" + _subjectId + "&groupId=" + groupId);
                request.Headers.Add("Authorization", _services.Preferences.AccessToken);
        Severity: Major
        Found in source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs and 2 other locations - About 3 hrs to fix
        source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs on lines 38..58
        source/EduCATS/Pages/SaveLabsAndPracticeMarks/Views/SavePracticeAndLabsPageViewModel.cs on lines 60..80

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 209.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        foreach (var subGroupStudent in fullVisitingLabs.Students.Where(v => v.SubGroup == selSubGroup))
                {
                    foreach (var stud in subGroupStudent.LabVisitingMark.Where(v => v.ScheduleProtectionLabId == labVisId))
                    {
                        _currentLabsVisitingMarksSubGroup1.Add(new VisitingPageModel(subGroupStudent.FullName,
        Severity: Major
        Found in source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs and 1 other location - About 1 hr to fix
        source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs on lines 447..454

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        foreach (var subGroupStudent in fullVisitingLabs.Students.Where(v => v.SubGroup == selSubGroup))
                {
                    foreach (var stud in subGroupStudent.LabVisitingMark.Where(v => v.ScheduleProtectionLabId == labVisId))
                    {
                        _currentLabsVisitingMarksSubGroup1.Add(new VisitingPageModel(subGroupStudent.FullName,
        Severity: Major
        Found in source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs and 1 other location - About 1 hr to fix
        source/EduCATS/Pages/SaveMarks/ViewModels/SaveMarksPageViewModel.cs on lines 416..423

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status