Sign upLogin

ilyalehchylin/educats-xamarin

View on GitHub
Star
source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs

Summary

Maintainability
F
4 days
Test Coverage

File StatsPageViewModel.cs has 601 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using System.Threading.Tasks;
Severity: Major
Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 1 day to fix

    Method getAndSetStatistics has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            protected virtual async Task getAndSetStatistics()
        {
            try
            {
                if (CurrentSubject != null)
    Severity: Major
    Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 3 hrs to fix

      Method calculateChartData has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              List<double> calculateChartData(StatsStudentModel stats, LabsVisitingList studentsPractStatistics, LabsVisitingList studentTestStatistics, LaboratoryWorksModel currentPractStudentStatistics, LaboratoryWorksModel worksModel)
        {
            double avgLabs = 0;
            double avgTests = 0;
            double avgPract = 0;
      Severity: Major
      Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 2 hrs to fix

        Method setChartData has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
        Open

                void setChartData(StatsStudentModel stats, LabsVisitingList studentsPractStatistics, LabsVisitingList studentTestStatistics, List<double> averages = null)
        {
            try {
                double rating = 0;
        Severity: Minor
        Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method setChartData has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                void setChartData(StatsStudentModel stats, LabsVisitingList studentsPractStatistics, LabsVisitingList studentTestStatistics, List<double> averages = null)
        {
            try {
                double rating = 0;
        Severity: Minor
        Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 1 hr to fix

          Method calculateChartData has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
          Open

                  List<double> calculateChartData(StatsStudentModel stats, LabsVisitingList studentsPractStatistics, LabsVisitingList studentTestStatistics, LaboratoryWorksModel currentPractStudentStatistics, LaboratoryWorksModel worksModel)
        {
            double avgLabs = 0;
            double avgTests = 0;
            double avgPract = 0;
          Severity: Minor
          Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

                          if (Servers.Current == Servers.EduCatsAddress)
                {

                    if (worksModel is not null && worksModel.PracticalsMarks.Count == 0 || worksModel is null && averages[2] == 0)
                    {
          Severity: Critical
          Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 1 hr to fix

            Method setPagesList has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    public void setPagesList()
        {
            if (_isPract && _isLabs)
            {
                PagesList = new List<StatsPageModel> {
            Severity: Minor
            Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 1 hr to fix

              Method openPage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      protected virtual void openPage(object selectedObject)
        {
            try
            {
                if (selectedObject == null || selectedObject.GetType() != typeof(StatsPageModel))
              Severity: Minor
              Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 1 hr to fix

                Method getPageToOpen has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        protected StatsPageEnum getPageToOpen(string pageString)
        {
            var labsRatingString = CrossLocalization.Translate("stats_page_labs_rating");
            var labsVisitingString = CrossLocalization.Translate("stats_page_labs_visiting");
            var practiseVisitingString = CrossLocalization.Translate("practiсe_visiting");
                Severity: Minor
                Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 1 hr to fix

                  Method getStatistics has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          protected virtual async Task<List<StatsStudentModel>> getStatistics()
        {
            try
            {
                if (!AppUserData.IsProfileLoaded)
                  Severity: Minor
                  Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 1 hr to fix

                    Method calculateChartData has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            List<double> calculateChartData(StatsStudentModel stats, LabsVisitingList studentsPractStatistics, LabsVisitingList studentTestStatistics, LaboratoryWorksModel currentPractStudentStatistics, LaboratoryWorksModel worksModel)
                    Severity: Minor
                    Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 35 mins to fix

                      Method getAndSetStatistics has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                      Open

                              protected virtual async Task getAndSetStatistics()
        {
            try
            {
                if (CurrentSubject != null)
                      Severity: Minor
                      Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid too many return statements within this method.
                      Open

                                      return StatsPageEnum.LecturesVisiting;
                      Severity: Major
                      Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs - About 30 mins to fix

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                double calculateAvgPractMarks(List<PracticialMarks> practicalsMarks)
        {
            if (practicalsMarks == null)
            {
                return 0;
                        Severity: Major
                        Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs and 2 other locations - About 1 hr to fix
                        source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs on lines 657..683
                        source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs on lines 685..707

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 131.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                double calculateAvgLabsMarkTest(List<LabMarks> marks)
        {
            if (marks == null)
            {
                return 0;
                        Severity: Major
                        Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs and 2 other locations - About 1 hr to fix
                        source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs on lines 596..622
                        source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs on lines 685..707

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 131.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                double calculateAvgLabsMark(IList<StatsMarkModel> marks)
        {
            if (marks == null) {
                return 0;
            }
                        Severity: Major
                        Found in source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs and 2 other locations - About 1 hr to fix
                        source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs on lines 596..622
                        source/EduCATS/Pages/Statistics/Base/ViewModels/StatsPageViewModel.cs on lines 657..683

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 131.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status