ilyalehchylin/educats-xamarin

View on GitHub
source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs

Summary

Maintainability
D
2 days
Test Coverage

File StatsResultsPageViewModel.cs has 432 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using System.Threading.Tasks;

    Method setLabsVisiting has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            void setLabsVisiting(StatsStudentModel student, LaboratoryWorksModel labs)
            {
                if (_statisticsPage == StatsPageEnum.LabsVisiting)
                {
                    if (Servers.Current == Servers.EduCatsAddress)

      Method setMarks has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              void setMarks(StatsStudentModel student, LaboratoryWorksModel labs)
              {
                  if (_statisticsPage == StatsPageEnum.LabsRating)
                  {
                      if (Servers.Current == Servers.EduCatsAddress)

        Method getLecturesVisiting has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                async Task getLecturesVisiting()
                {
                    LecturesModel visitingData = new LecturesModel();
        
                    var listLectures = await DataAccess.GetInfoLectures(_currentSubjectId);

          Method getData has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  async Task getData()
                  {
                      try {
                          switch (_statisticsPage) {
                              case StatsPageEnum.LabsRating:

            Method getPractMarkAndVisiting has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    async Task getPractMarkAndVisiting()
                    {
                        StatsModel stats = new StatsModel();
                        LabsVisitingList statsTest = new LabsVisitingList();
                        statsTest = await DataAccess.GetTestPracticialStatistics(_currentSubjectId, _currentGroupId);

              Method setVisitingLabsStatistics has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      void setVisitingLabsStatistics(LabsModel dataLabs, TakedLabs takedLabs)
                      {
                          _takedLabs = takedLabs.Labs;
              
                          var labsTetsVisitingStatus = takedLabs.ScheduleProtectionLabs?.Select(labs =>

                Method setLabsVisiting has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
                Open

                        void setLabsVisiting(StatsStudentModel student, LaboratoryWorksModel labs)
                        {
                            if (_statisticsPage == StatsPageEnum.LabsVisiting)
                            {
                                if (Servers.Current == Servers.EduCatsAddress)

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                                            if (queueTheme.Count > 0)
                                            {
                                                theme = queueTheme.Dequeue();
                                            }

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                              var student = stats?.Students?.SingleOrDefault(
                                  s => string.Compare(s.Name?.ToLower(), _currentUserName?.ToLower()) == 0);
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 139..140
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 141..142
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 162..163

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                              var student = stats?.Students?.SingleOrDefault(
                                  s => string.Compare(s.Name?.ToLower(), _currentUserName?.ToLower()) == 0);
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 141..142
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 160..161
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 162..163

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                              var studentTest = statsTest?.Students?.SingleOrDefault(
                                  s => string.Compare(s.FullName?.ToLower(), _currentUserName?.ToLower()) == 0);
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 139..140
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 160..161
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 162..163

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                              var studentTest = statsTest?.Students?.SingleOrDefault(
                                  s => string.Compare(s.FullName?.ToLower(), _currentUserName?.ToLower()) == 0);
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 139..140
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 141..142
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 160..161

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                              if (Servers.Current == Servers.EduCatsAddress)
                              {
                                  statsTest = await DataAccess.GetTestStatistics(_currentSubjectId, _currentGroupId);
                              }
                              else
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 215..222
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 307..314

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                              if (Servers.Current == Servers.EduCatsAddress)
                              {
                                  visitingData = await DataAccess.GetLecturesTest(_currentSubjectId, _currentGroupId);
                              }
                              else
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 130..137
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 215..222

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                              if (Servers.Current == Servers.EduCatsAddress)
                              {
                                  dataTestLabs = await DataAccess.GetLabsTest(_currentSubjectId, _currentGroupId);
                              }
                              else
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 130..137
                  source/EduCATS/Pages/Statistics/Results/ViewModels/StatsResultsPageViewModel.cs on lines 307..314

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status