ilyalehchylin/educats-xamarin

View on GitHub
source/EduCATS/Pages/Today/Base/ViewModels/TodayPageViewModel.cs

Summary

Maintainability
D
2 days
Test Coverage

File TodayPageViewModel.cs has 559 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Linq;
using System.Net.Http;
Severity: Major
Found in source/EduCATS/Pages/Today/Base/ViewModels/TodayPageViewModel.cs - About 1 day to fix

    Class TodayPageViewModel has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

        public class TodayPageViewModel : ViewModel
        {
            readonly IPlatformServices _services;
    
            readonly double _subjectHeight;
    Severity: Minor
    Found in source/EduCATS/Pages/Today/Base/ViewModels/TodayPageViewModel.cs - About 2 hrs to fix

      Method getAndSetCalendarNotes has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              async Task getAndSetCalendarNotes()
              {
                  if (_services.Preferences.Server == Networking.Servers.EduCatsBntuAddress)
                  {
                      var calendar = await DataAccess.GetProfileInfoCalendar(_services.Preferences.UserLogin);
      Severity: Minor
      Found in source/EduCATS/Pages/Today/Base/ViewModels/TodayPageViewModel.cs - About 1 hr to fix

        Method changeCalendarSelection has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                void changeCalendarSelection(
                    CalendarViewModel calendarModel,
                    CalendarViewDayModel calendarDayModel,
                    bool selected)
                {
        Severity: Minor
        Found in source/EduCATS/Pages/Today/Base/ViewModels/TodayPageViewModel.cs - About 1 hr to fix

          Method calendarPositionChangedEvent has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  protected void calendarPositionChangedEvent(CarouselView.FormsPlugin.Abstractions.PositionSelectedEventArgs e)
                  {
                      try
                      {
                          selectTodayDateWithoutSelectedFlag();
          Severity: Minor
          Found in source/EduCATS/Pages/Today/Base/ViewModels/TodayPageViewModel.cs - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                        if ((Convert.ToInt32(a[0]) > Convert.ToInt32(b[0])) ||
                            (Convert.ToInt32(a[1]) > Convert.ToInt32(b[1]) && Convert.ToInt32(a[0]) == Convert.ToInt32(b[0])) ||
                            (Convert.ToInt32(a[2]) > Convert.ToInt32(b[2]) && Convert.ToInt32(a[0]) == Convert.ToInt32(b[0]) &&
                            Convert.ToInt32(a[1]) == Convert.ToInt32(b[1])))
                        {
            Severity: Major
            Found in source/EduCATS/Pages/Today/Base/ViewModels/TodayPageViewModel.cs - About 40 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              (Convert.ToInt32(a[2]) > Convert.ToInt32(b[2]) && Convert.ToInt32(a[0]) == Convert.ToInt32(b[0]) &&
              source/EduCATS/Pages/Today/Base/ViewModels/TodayPageViewModel.cs on lines 295..295

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              (Convert.ToInt32(a[1]) > Convert.ToInt32(b[1]) && Convert.ToInt32(a[0]) == Convert.ToInt32(b[0])) ||
              source/EduCATS/Pages/Today/Base/ViewModels/TodayPageViewModel.cs on lines 296..296

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status