Sign upLogin

imagecms/ImageCMS

View on GitHub
Star
application/modules/exchange/classes/Properties.php

Summary

Maintainability
C
1 day
Test Coverage

Function processProperties has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    protected function processProperties() {
        foreach ($this->importData as $property) {
            $propertyData = [];
            $externalId = (string) $property->Ид;
            $name = (string) $property->Наименование;
Severity: Minor
Found in application/modules/exchange/classes/Properties.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method processProperties has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function processProperties() {
        foreach ($this->importData as $property) {
            $propertyData = [];
            $externalId = (string) $property->Ид;
            $name = (string) $property->Наименование;
Severity: Minor
Found in application/modules/exchange/classes/Properties.php - About 1 hr to fix

Method insertBrands has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function insertBrands() {

        // getting existing brands
        $result = $this->db
            ->select(['id', 'name'])
Severity: Minor
Found in application/modules/exchange/classes/Properties.php - About 1 hr to fix

Method getBrandIdByName has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getBrandIdByName($brandName) {

        if (!is_string($brandName) || !isset($brandName[0])) {
            return null;
        }
Severity: Minor
Found in application/modules/exchange/classes/Properties.php - About 1 hr to fix

Function insertBrands has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    protected function insertBrands() {

        // getting existing brands
        $result = $this->db
            ->select(['id', 'name'])
Severity: Minor
Found in application/modules/exchange/classes/Properties.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processPropertiesValues has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private function processPropertiesValues() {
        foreach ($this->properties as $property) {

            if(array_key_exists($property['external_id'], $this->dictionaryProperties)) {
                foreach ($this->dictionaryProperties[$property['external_id']] as $key => $values) {
Severity: Minor
Found in application/modules/exchange/classes/Properties.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return $brandId;
Severity: Major
Found in application/modules/exchange/classes/Properties.php - About 30 mins to fix

Function getBrandIdByName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getBrandIdByName($brandName) {

        if (!is_string($brandName) || !isset($brandName[0])) {
            return null;
        }
Severity: Minor
Found in application/modules/exchange/classes/Properties.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status