Sign upLogin

inossidabile/heimdallr

View on GitHub
Star
lib/heimdallr/legacy_resource.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method with_objects_from_params has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def with_objects_from_params(options={})
      model.transaction do
        if @multiple_resources
          begin
            name = model.name.underscore.pluralize
Severity: Minor
Found in lib/heimdallr/legacy_resource.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method render_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def render_data(options={})
      if @multiple_resources
        if options[:verify] && @resources.any?(&:invalid?)
          render :json => { errors: @resources.map(&:errors) }, :status => :unprocessable_entity
        else
Severity: Minor
Found in lib/heimdallr/legacy_resource.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status