instacart/redux-rails

File apiReducer.js has 327 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { combineReducers } from 'redux'
import {
  apiDefaultState,
  findModel,
  createNewModel,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export const index = ({resource, controller, queryParams}) => {
  return {
    type: `${resource}.INDEX`,
    data: { queryParams },
    controller

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export const destroy = ({id, resource, controller}) => {
  return {
    type: `${resource}.DESTROY`,
    data: { id },
    controller

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export const destroyMember = ({id, state}) => {
  return state.models.filter(model => model.id !== id)
}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export const destroyTempMemeber = ({cId, state}) => {
  return state.models.filter(model => model.cId !== cId)
}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          dispatchFetchError({store, resource, railsAction, error: outError, id: data.id, cId, optimisticUpdateEnabled, reject})

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      dispatchFetchError({store, resource, railsAction, error, id: data.id, cId, optimisticUpdateEnabled, reject})

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          if (isSingleModel) {
            return createNewModel({id, cId,
              attributes: { ...currentModel.attributes, ...data },
              metaData: newMeta
            })

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          if (isSingleModel) {
            return createNewModel({id, cId,
              attributes: { ...state.attributes, ...data },
              metaData
            })

• Read up
  Read up

Avoid too many return statements within this function.

Open

            return { 
              ...state,
              ...{
                loading: false,
                loadingError: error

Avoid too many return statements within this function.

Open

          return {
            ...state,
            ...{ models: setMemberLoading({id, state, queryParams}) }
          }

Avoid too many return statements within this function.

Open

          return {
            ...state,
            ...{ models: setMemberLoadingError({state, id, error}) }
          }

Avoid too many return statements within this function.

Open

  return true

Avoid too many return statements within this function.

Open

            return createNewModel({id, cId,
              attributes: { ...state.attributes, ...data },
              metaData
            })

Avoid too many return statements within this function.

Open

          return {
            ...state,
            ...{ models: setMemberLoading({idAttribute, id, state}) }
          }

Avoid too many return statements within this function.

Open

          return state

Avoid too many return statements within this function.

Open

          return createNewCollection({
            models: setMemberAttributes({data, state, id, cId, metaData})
          })

Avoid too many return statements within this function.

Open

            return null

Avoid too many return statements within this function.

Open

          return createNewCollection({
            models: setMemberAttributes({data, state, id, cId, metaData: newMeta})
          })

Avoid too many return statements within this function.

Open

            return {
              ...state,
              ...{ models: destroyTempMemeber({cId, state}) }
            }