Sign upLogin

instacart/redux-rails

View on GitHub
Star

Showing 45 of 45 total issues

Avoid too many return statements within this function.
Open

          return {
            ...state,
            ...{ models: setMemberLoadingError({state, id, cId, error}) }
          }
Severity: Major
Found in src/apiReducer.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

              return {
            ...state,
            ...{ models: setMemberLoading({idAttribute, id, state}) }
          }
    Severity: Major
    Found in src/apiReducer.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                return {
            ...state,
            ...{ models: setMemberLoadingError({state, id, idAttribute, error}) }
          }
      Severity: Major
      Found in src/apiReducer.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                  return createNewCollection({
            models: setMemberAttributes({data: currentModel.__prevData, state, id, cId})
          })
        Severity: Major
        Found in src/apiReducer.js - About 30 mins to fix

          Function parseResult has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          const parseResult = ({json, resource, config, resourceType}) => {
  const resourceParse = config.resources[resource].parse
  const resourceMeta = config.resources[resource].setMetadata
  let response
  let metaData = {}
          Severity: Minor
          Found in src/middleWare.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language