integreat-io/integreat-transporter-mongodb

View on GitHub

Showing 34 of 35 total issues

File setDocs.ts has 371 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable security/detect-object-injection */
import debug from 'debug'
import prepareFilter from './utils/prepareFilter.js'
import { serializeItem } from './utils/serialize.js'
import { isObject, isObjectWithId, ObjectWithId } from './utils/is.js'
Severity: Minor
Found in src/setDocs.ts - About 4 hrs to fix

    Function setMongoSelectorFromQueryObj has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    function setMongoSelectorFromQueryObj(
      allParams: Record<string, unknown>,
      { path, op = 'eq', value, valuePath, param, variable, expr }: QueryObject,
      useIdAsInternalId: boolean,
      filter = {},
    Severity: Minor
    Found in src/utils/prepareFilter.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File prepareAggregation.ts has 335 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
      GroupMethod,
      GroupObject,
      AggregationObject,
      AggregationObjectGroup,
    Severity: Minor
    Found in src/utils/prepareAggregation.ts - About 4 hrs to fix

      Function getDocs has 96 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default async function getDocs(
        action: Action,
        client: MongoClient,
        useIdAsInternalId = false,
      ): Promise<Response> {
      Severity: Major
      Found in src/getDocs.ts - About 3 hrs to fix

        Function updateMany has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

        async function updateMany(
          operations: Operation[],
          collection: Collection,
          action: Action,
        ) {
        Severity: Minor
        Found in src/setDocs.ts - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File getDocs.ts has 279 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import assert from 'node:assert/strict'
        import debug from 'debug'
        import mapAny from 'map-any'
        import { getProperty, setProperty } from 'dot-prop'
        import prepareFilter from './utils/prepareFilter.js'
        Severity: Minor
        Found in src/getDocs.ts - About 2 hrs to fix

          Function updateMany has 52 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          async function updateMany(
            operations: Operation[],
            collection: Collection,
            action: Action,
          ) {
          Severity: Major
          Found in src/setDocs.ts - About 2 hrs to fix

            Function getDocs has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

            export default async function getDocs(
              action: Action,
              client: MongoClient,
              useIdAsInternalId = false,
            ): Promise<Response> {
            Severity: Minor
            Found in src/getDocs.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function connect has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export default async function connect(
              Client: typeof MongoClient,
              options: ServiceOptions,
              emit: (eventType: string, ...args: unknown[]) => void,
              auth?: Record<string, unknown> | null,
            Severity: Minor
            Found in src/connect.ts - About 1 hr to fix

              Function listen has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export default async function listen(
                dispatch: Dispatch,
                connection: Connection | null,
                authenticate: AuthenticateExternal,
              ): Promise<Response> {
              Severity: Minor
              Found in src/listen.ts - About 1 hr to fix

                Function createOrReuseClient has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                async function createOrReuseClient(
                  Client: typeof MongoClient,
                  mongoUri: string,
                  options: MongoClientOptions,
                  emit: (eventType: string, ...args: unknown[]) => void,
                Severity: Minor
                Found in src/connect.ts - About 1 hr to fix

                  Function setDocs has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  export default async function setDocs(
                    action: Action,
                    client: MongoClient,
                    useIdAsInternalId = false,
                  ): Promise<Response> {
                  Severity: Minor
                  Found in src/setDocs.ts - About 1 hr to fix

                    Function updateOne has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    async function updateOne(
                      operation: Operation,
                      collection: Collection,
                      action: Action,
                    ) {
                    Severity: Minor
                    Found in src/setDocs.ts - About 1 hr to fix

                      Function toMongo has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        function toMongo(obj: AggregationObject) {
                          switch (obj.type) {
                            case 'group':
                              return groupToMongo(obj, useIdAsInternalId)
                            case 'sort':
                      Severity: Minor
                      Found in src/utils/prepareAggregation.ts - About 1 hr to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                          const {
                            payload: { data, ...params },
                            meta: { options: { keepUndefined = false, appendOnly = false } = {} } = {},
                          } = action
                        Severity: Major
                        Found in src/setDocs.ts and 1 other location - About 1 hr to fix
                        src/setDocs.ts on lines 165..170

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 62.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            const {
                              payload: { data, ...params },
                              meta: {
                                options: { keepUndefined = false, appendOnly = false } = {},
                              } = {},
                        Severity: Major
                        Found in src/setDocs.ts and 1 other location - About 1 hr to fix
                        src/setDocs.ts on lines 136..139

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 62.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function createOperation has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          function createOperation(item: unknown): Operation | OperationError {
                            if (!isObjectWithId(item)) {
                              return { error: 'Only object data with an id may be sent to MongoDB' }
                            }
                        
                        
                        Severity: Minor
                        Found in src/setDocs.ts - About 1 hr to fix

                          Function disconnect has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export default async function disconnect(
                            connection: Connection | null,
                          ): Promise<void> {
                            if (connection?.status === 'ok' && connection.mongo) {
                              connection.mongo.count -= 1
                          Severity: Minor
                          Found in src/disconnect.ts - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function updateOne has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                          Open

                          async function updateOne(
                            operation: Operation,
                            collection: Collection,
                            action: Action,
                          ) {
                          Severity: Minor
                          Found in src/setDocs.ts - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function prepareFilter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export default function prepareFilter(
                            queryArray: QueryArray = [],
                            params: Params = {},
                            pageId?: ParsedPageId,
                            useIdAsInternalId = false,
                          Severity: Minor
                          Found in src/utils/prepareFilter.ts - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language