Showing 35 of 36 total issues
Function connect
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Client: typeof MongoClient,
options: ServiceOptions,
emit: (eventType: string, ...args: unknown[]) => void,
auth?: Record<string, unknown> | null,
connection: Connection | null = null,
Function createOrReuseClient
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Client: typeof MongoClient,
mongoUri: string,
options: MongoClientOptions,
emit: (eventType: string, ...args: unknown[]) => void,
throwAfterFailedHeartbeatCount?: number,
Function prepareFilter
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
queryArray: QueryArray = [],
params: Params = {},
pageId?: ParsedPageId,
useIdAsInternalId = false,
appendOnly = false,
Function createResponse
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
const createResponse = (
oneOrMoreResponses: ItemResponse | ItemResponse[],
action: Action,
): Response => {
const responses = ensureArray(oneOrMoreResponses)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
export const isTypedData = (value: unknown): value is TypedData =>
isObject(value) && typeof value.id === 'string'
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 45.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid too many return
statements within this function. Open
return createErrorResponse('error', (error as Error).message, operation.id)
Avoid too many return
statements within this function. Open
return createResponse(responses, action)
Function createOperation
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
const createOperation = (action: Action, useIdAsInternalId: boolean) =>
function createOperation(item: unknown): Operation | OperationError {
if (!isObjectWithId(item)) {
return { error: 'Only object data with an id may be sent to MongoDB' }
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function createOrReuseClient
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
async function createOrReuseClient(
Client: typeof MongoClient,
mongoUri: string,
options: MongoClientOptions,
emit: (eventType: string, ...args: unknown[]) => void,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function generatePageId
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function generatePageId(
lastItem: unknown,
sort?: Record<string, number>,
aggregation?: AggregationObject[],
) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function normalizeIdInItem
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
const normalizeIdInItem = (lookupPaths: string[]) =>
function normalizeIdInItem(item: unknown) {
if (!isObject(item)) {
return item
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function setDocs
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
export default async function setDocs(
action: Action,
client: MongoClient,
useIdAsInternalId = false,
): Promise<Response> {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function generateSortParts
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function generateSortParts(
lastItem: Record<string, unknown>,
sort?: Record<string, number>,
): string {
if (sort) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function isValidValue
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
const isValidValue = (value: unknown, op: string): boolean =>
Array.isArray(value)
? value.every((value) => isValidValue(value, op))
: validValueTypes.includes(typeof value) ||
value instanceof Date ||
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function dearrayIfPossible
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
export const dearrayIfPossible = <T>(data: T | T[]): T | T[] | undefined =>
Array.isArray(data)
? data.length === 1
? data[0]
: data.length === 0
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"