intridea/grape

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  module Extensions
    module Hashie
      module Mash
        module ParamBuilder
          extend ::ActiveSupport::Concern

Found in lib/grape/extensions/hashie/mash.rb and 1 other location - About 45 mins to fix

Read up
Read up

lib/grape/extensions/active_support/hash_with_indifferent_access.rb on lines 4..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  module Extensions
    module ActiveSupport
      module HashWithIndifferentAccess
        module ParamBuilder
          extend ::ActiveSupport::Concern

Found in lib/grape/extensions/active_support/hash_with_indifferent_access.rb and 1 other location - About 45 mins to fix

Read up
Read up

lib/grape/extensions/hashie/mash.rb on lines 4..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Method `call` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def call(message, backtrace, options = {}, env = nil, original_exception = nil)
          message = present(message, env)

          result = message.is_a?(Hash) ? message : { message: message }
          rescue_options = options[:rescue_options] || {}

Found in lib/grape/error_formatter/xml.rb - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `transaction` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def transaction(env)
      input, method = *extract_input_and_method(env)
      response = yield(input, method)

      return response if response && !(cascade = cascade?(response))

Found in lib/grape/router.rb - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `validate_param!` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def validate_param!(attr_name, params)
          return if (options_key?(:value) ? @option[:value] : @option) || !params.is_a?(Hash)

          value = params[attr_name]
          value = value.strip if value.respond_to?(:strip)

Found in lib/grape/validations/validators/allow_blank_validator.rb - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `guess_coerce_type` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def guess_coerce_type(coerce_type, *values_list)
        return coerce_type unless coerce_type == Array

        values_list.each do |values|
          next if !values || values.is_a?(Proc)

Found in lib/grape/validations/params_scope.rb - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `header` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def header(key = nil, val = nil)
        if key
          val ? header[key.to_s] = val : header.delete(key.to_s)
        else
          @header ||= Grape::Util::Header.new

Found in lib/grape/dsl/headers.rb - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `declared_hash_attr` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def declared_hash_attr(passed_params, options, declared_param, params_nested_path, memo)

Found in lib/grape/dsl/inside_route.rb - About 35 mins to fix

Method `initialize` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def initialize(attrs, options, required, scope, *opts)

Found in lib/grape/validations/validators/base.rb - About 35 mins to fix

Method `initialize` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def initialize(attrs, options, required, scope, **opts)

Found in lib/grape/validations/validators/default_validator.rb - About 35 mins to fix

Method `validate` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def validate(type, options, attrs, doc, opts)

Found in lib/grape/validations/params_scope.rb - About 35 mins to fix

Method `call` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def call(message, backtrace, options = {}, env = nil, original_exception = nil)

Found in lib/grape/error_formatter/txt.rb - About 35 mins to fix

Method `initialize` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def initialize(attrs, options, required, scope, **opts)

Found in lib/grape/validations/validators/coerce_validator.rb - About 35 mins to fix

Method `initialize` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def initialize(attrs, options, required, scope, **opts)

Found in lib/grape/validations/validators/except_values_validator.rb - About 35 mins to fix

Method `error!` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def error!(message, status = options[:default_status], headers = {}, backtrace = [], original_exception = nil)

Found in lib/grape/middleware/error.rb - About 35 mins to fix

Method `initialize` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def initialize(attrs, options, required, scope, **opts)

Found in lib/grape/validations/validators/values_validator.rb - About 35 mins to fix

Method `call` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def call(message, backtrace, options = {}, env = nil, original_exception = nil)

Found in lib/grape/error_formatter/xml.rb - About 35 mins to fix

Method `call` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def call(message, backtrace, options = {}, env = nil, original_exception = nil)

Found in lib/grape/error_formatter/json.rb - About 35 mins to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

          if Types.multiple?(type)
            MultipleTypeCoercer.new(type, method)

            # Use a special coercer for custom types and coercion methods.
          elsif method || Types.custom?(type)

Found in lib/grape/validations/types/build_coercer.rb and 1 other location - About 35 mins to fix

Read up
Read up

lib/grape/validations/types.rb on lines 168..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if Types.multiple?(type)
          MultipleTypeCoercer.new(type, method)

          # Use a special coercer for custom types and coercion methods.
        elsif method || Types.custom?(type)

Found in lib/grape/validations/types.rb and 1 other location - About 35 mins to fix

Read up
Read up

lib/grape/validations/types/build_coercer.rb on lines 46..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76