Sign upLogin

ionelmc/python-aspectlib

View on GitHub
Star

Showing 55 of 55 total issues

Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, wrapped, iscalled=True, calls=None, callback=None, extended=False, results=False, recurse_lock=None, binding=None):
Severity: Major
Found in src/aspectlib/test.py - About 1 hr to fix

    Function _rewrap_method has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def _rewrap_method(func, klass, aspect):
    if isinstance(func, staticmethod):
        if hasattr(func, '__func__'):
            return staticmethod(_checked_apply(aspect, func.__func__))
        else:
    Severity: Minor
    Found in src/aspectlib/__init__.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function exec_in_env has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def exec_in_env():
    env_path = join(base_path, ".tox", "bootstrap")
    if sys.platform == "win32":
        bin_path = join(env_path, "Scripts")
    else:
    Severity: Minor
    Found in ci/bootstrap.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function patch_module has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def patch_module(module, name, replacement, original=UNSPECIFIED, aliases=True, location=None, **_bogus_options):
    Severity: Major
    Found in src/aspectlib/__init__.py - About 50 mins to fix

      Function weave_module has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def weave_module(module, aspect, methods=NORMAL_METHODS, lazy=False, bag=BrokenBag, **options):
      Severity: Minor
      Found in src/aspectlib/__init__.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            for attr, func in sklass.__dict__.items():
                        if method_matches(attr) and attr not in original and attr not in super_original:
                            if isroutine(func):
                                logdebug("@ patching attribute %r (from superclass: %s, original: %r).", attr, sklass.__name__, func)
                                setattr(klass, attr, _rewrap_method(func, sklass, aspect))
        Severity: Major
        Found in src/aspectlib/__init__.py - About 45 mins to fix

          Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, play, proxy=True, strict=True, dump=True, recurse_lock=False, **options):
          Severity: Minor
          Found in src/aspectlib/test.py - About 45 mins to fix

            Function weave_module has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            def weave_module(module, aspect, methods=NORMAL_METHODS, lazy=False, bag=BrokenBag, **options):
    """
    Low-level weaver for "whole module weaving".

    .. warning:: You should not use this directly.
            Severity: Minor
            Found in src/aspectlib/__init__.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _callback has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def _callback(self, _binding, qualname, args, _kwargs):
        _, name = qualname.rsplit('.', 1)

        if name == 'log':
            level, args = _checkLevel(args[0]), args[1:]
            Severity: Minor
            Found in src/aspectlib/test.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _handle has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def _handle(self, binding, name, args, kwargs, wrapped, bind=None):
            Severity: Minor
            Found in src/aspectlib/test.py - About 45 mins to fix

              Function retry has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def retry(func=None, retries=5, backoff=None, exceptions=(IOError, OSError, EOFError), cleanup=None, sleep=time.sleep):
              Severity: Minor
              Found in src/aspectlib/contrib.py - About 45 mins to fix

                Function weave_instance has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def weave_instance(instance, aspect, methods=NORMAL_METHODS, lazy=False, bag=BrokenBag, **options):
                Severity: Minor
                Found in src/aspectlib/__init__.py - About 45 mins to fix

                  Function patch_module_function has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def patch_module_function(module, target, aspect, force_name=None, bag=BrokenBag, **options):
                  Severity: Minor
                  Found in src/aspectlib/__init__.py - About 45 mins to fix

                    Consider simplifying this complex logical expression.
                    Open

                        if name and getattr(builtins, name, None) is target:
        if bag.has(target):
            return Nothing
        return patch_module_function(builtins, target, aspects, **options)
    elif PY3 and ismethod(target):
                    Severity: Major
                    Found in src/aspectlib/__init__.py - About 40 mins to fix

                      Function _handle has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def _handle(self, binding, name, args, kwargs, result):
                      Severity: Minor
                      Found in src/aspectlib/test.py - About 35 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return weave_instance(target, aspects, **options)
                        Severity: Major
                        Found in src/aspectlib/__init__.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return mimic(advising_function_wrapper, cutpoint_function)
                          Severity: Major
                          Found in src/aspectlib/__init__.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return patch_module_function(builtins, target, aspects, **options)
                            Severity: Major
                            Found in src/aspectlib/__init__.py - About 30 mins to fix

                              Similar blocks of code found in 4 locations. Consider refactoring.
                              Open

                                  set: lambda obj, aliases: "set([%s])" % ', '.join(repr_ex(i) for i in obj),
                              Severity: Major
                              Found in src/aspectlib/utils.py and 3 other locations - About 30 mins to fix
                              src/aspectlib/utils.py on lines 127..127
                              src/aspectlib/utils.py on lines 129..129
                              src/aspectlib/utils.py on lines 130..130

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 32.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Avoid too many return statements within this function.
                              Open

                                      return repr(obj)
                              Severity: Major
                              Found in src/aspectlib/utils.py - About 30 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language