Sign upLogin

ipfs/ipfs-cluster

View on GitHub
Star
adder/single/dag_service.go

Summary

Maintainability
A
45 mins
Test Coverage

Method DAGService.Add has a Cognitive Complexity of 18 (exceeds 15 allowed). Consider refactoring.
Open

func (dgs *DAGService) Add(ctx context.Context, node ipld.Node) error {
    // Avoid adding the same node multiple times in a row.
    // This is done by the ipfsadd-er, because some nodes are added
    // via dagbuilder, then via MFS, and root nodes once more.
    if dgs.recentBlocks.Has(node) {
Severity: Minor
Found in adder/single/dag_service.go - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

FIXME found
Open

    // FIXME: can't this happen on initialization?  Perhaps the point here
Severity: Minor
Found in adder/single/dag_service.go by fixme

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Package single implements a ClusterDAGService that chunks and adds content
Severity: Minor
Found in adder/single/dag_service.go by gofmt

There are no issues that match your filters.

Category
Status