Sign upLogin

iranianpep/code-jetter

View on GitHub
Star

Showing 1,173 of 1,173 total issues

The class BaseMapper has 13 public methods. Consider refactoring BaseMapper to keep number of public methods under 10.
Open

abstract class BaseMapper extends Base implements ICrud
{
    protected $database;
    protected $table;
    protected $modelName;
Severity: Minor
Found in core/BaseMapper.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class BaseMapper has an overall complexity of 84 which is very high. The configured complexity threshold is 50.
Open

abstract class BaseMapper extends Base implements ICrud
{
    protected $database;
    protected $table;
    protected $modelName;
Severity: Minor
Found in core/BaseMapper.php by phpmd

The class ErrorHandler has an overall complexity of 70 which is very high. The configured complexity threshold is 50.
Open

class ErrorHandler
{
    private $configs;
    private $logger;
Severity: Minor
Found in core/ErrorHandler.php by phpmd

The class Validator has an overall complexity of 123 which is very high. The configured complexity threshold is 50.
Open

class Validator
{
    /**
     * @var array
     */
Severity: Minor
Found in core/security/Validator.php by phpmd

The class Request has an overall complexity of 62 which is very high. The configured complexity threshold is 50.
Open

class Request
{
    private $requestMethod;
    private $inputs;
    private $queryString;
Severity: Minor
Found in core/io/Request.php by phpmd

The class QueryMaker has an overall complexity of 116 which is very high. The configured complexity threshold is 50.
Open

class QueryMaker
{
    private $tables;
    private $validComparisonOperators = ['LIKE', 'NOT LIKE', '=', '!=', '<>', '<', '<=', '>', '>=', '<=>', 'IS NOT',
        'IS', 'IS NOT NULL', 'IS NULL', 'IN', 'NOT IN', ];
Severity: Minor
Found in core/database/QueryMaker.php by phpmd

The class Router has an overall complexity of 73 which is very high. The configured complexity threshold is 50.
Open

class Router
{
    private static $defaultComponent;
    private static $defaultController;
    private static $defaultAction;
Severity: Minor
Found in core/Router.php by phpmd

File script.js has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

$(document).ready(function(){
    toastr.options = {
        "closeButton": true,
        "progressBar": true,
        "preventDuplicates": true,
Severity: Minor
Found in public/scripts/script.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        if (response.message !== undefined) {
                        // convert array to string using join
                        var message = '';
                        if (typeof response.message == 'undefined' || !response.message || response.message.length === 0) {
                            message = response.messages.join('<br>');
    Severity: Major
    Found in public/scripts/script.js and 1 other location - About 3 hrs to fix
    public/scripts/script.js on lines 88..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 98.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    } else {
                    // convert array to string using join
                    var message = '';
                    if (typeof response.message == 'undefined' || !response.message || response.message.length === 0) {
                        message = response.messages.join('<br>');
    Severity: Major
    Found in public/scripts/script.js and 1 other location - About 3 hrs to fix
    public/scripts/script.js on lines 57..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 98.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File MemberUserMapper.php has 297 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace CodeJetter\components\user\mappers;

use CodeJetter\components\user\models\MemberUser;
    Severity: Minor
    Found in components/user/mappers/MemberUserMapper.php - About 3 hrs to fix

      Function appendDataObjectToForm has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

      function appendDataObjectToForm(data, form, whitelist)
{
    if (typeof data != "undefined" && typeof form != "undefined") {

        var foundDiv = $(form).find('.appended-data');
      Severity: Minor
      Found in public/scripts/script.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getRouteInfo has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getRouteInfo($urlPath, $requestMethod)
    {
        if (empty($requestMethod)) {
            return false;
        }
      Severity: Minor
      Found in core/Router.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function loginForm()
    {
        $page = new Page($this->getRouteInfo()->getAccessRole());
        $page->setTitle('Login');
      Severity: Major
      Found in components/user/controllers/AdminUserController.php and 1 other location - About 2 hrs to fix
      components/user/controllers/MemberUserController.php on lines 101..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 140.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function loginForm()
    {
        $page = new Page($this->getRouteInfo()->getAccessRole());
        $page->setTitle('Login');
      Severity: Major
      Found in components/user/controllers/MemberUserController.php and 1 other location - About 2 hrs to fix
      components/user/controllers/AdminUserController.php on lines 42..70

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 140.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File Router.php has 288 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

namespace CodeJetter\core;

use CodeJetter\components\page\models\MetaTag;
      Severity: Minor
      Found in core/Router.php - About 2 hrs to fix

        File RouterTest.php has 287 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

namespace CodeJetter\tests;

use CodeJetter\core\App;
        Severity: Minor
        Found in tests/RouterTest.php - About 2 hrs to fix

          Method where has 72 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function where(array $criteria)
    {
        if (!empty($criteria)) {
            $where = ' WHERE ';
          Severity: Major
          Found in core/database/QueryMaker.php - About 2 hrs to fix

            Method testValidateUsername has 71 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function testValidateUsername()
    {
        $app = App::getInstance();
        $app->init('dev');
            Severity: Major
            Found in tests/ValidatorTest.php - About 2 hrs to fix

              Method testValidateSize has 71 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function testValidateSize()
    {
        $app = App::getInstance();
        $app->init('dev');
              Severity: Major
              Found in tests/ValidatorTest.php - About 2 hrs to fix
                Severity
                Category
                Status
                Source
                Language