Sign upLogin

iranianpep/code-jetter

View on GitHub
Star

Showing 1,173 of 1,173 total issues

Method update has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function update(
        array $criteria,
        array $inputs,
        array $fieldsValues,
        $limit = 0,
Severity: Major
Found in components/user/mappers/UserMapper.php - About 2 hrs to fix

    Method validate has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function validate()
    {
        $output = new Output();
        if ($this->isAlreadyValidated()) {
            // return the current output is already validated
    Severity: Major
    Found in core/security/Validator.php - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function addStyleFile($filePath, $orderNumber = null)
    {
        if ($orderNumber !== null) {
            // validate order number
            if (!is_numeric($orderNumber) || $orderNumber < 0) {
      Severity: Major
      Found in core/layout/blocks/BaseBlock.php and 1 other location - About 2 hrs to fix
      core/layout/blocks/BaseBlock.php on lines 122..143

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function addScriptFile($filePath, $orderNumber = null)
    {
        if ($orderNumber !== null) {
            // validate order number
            if (!is_numeric($orderNumber) || $orderNumber < 0) {
      Severity: Major
      Found in core/layout/blocks/BaseBlock.php and 1 other location - About 2 hrs to fix
      core/layout/blocks/BaseBlock.php on lines 175..196

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function getAccessRole has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getAccessRole($urlPath, $roles = [])
    {
        if (empty($roles)) {
            $roles = Registry::getConfigClass()->get('roles');
        }
      Severity: Minor
      Found in core/Router.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function regexMatch has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public function regexMatch($pattern, $path)
    {
        if (empty($pattern) || empty($path)) {
            return false;
        }
      Severity: Minor
      Found in core/Router.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getPersonalizedMenu has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getPersonalizedMenu()
    {
        $routeInfo = Registry::getRouterClass()->getLastRoute();

        if (!$routeInfo instanceof RouteInfo) {
      Severity: Minor
      Found in core/layout/blocks/Menu.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getSelectFromTables has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getSelectFromTables($fromColumns = null)
    {
        $joinedSelect = [];
        $counter = 1;
        $from = '';
      Severity: Minor
      Found in core/database/QueryMaker.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method listUsers has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function listUsers()
    {
        // for pagination - for simple router url path is enough, for regex ones base path is needed
        $pager = new Pager($this->getURLParameters(), $this->getBasePath(), $this->getRouteInfo()->getUrl());
      Severity: Major
      Found in components/user/controllers/MemberUserController.php - About 2 hrs to fix

        Method testValidateRequired has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function testValidateRequired()
    {
        $app = App::getInstance();
        $app->init('dev');
        Severity: Major
        Found in tests/ValidatorTest.php - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function singularToPlural($string)
    {
        // save some time in the case that singular and plural are the same
        if (in_array(strtolower($string), $this->uncountable)) {
            return $string;
          Severity: Major
          Found in core/utility/StringUtility.php and 1 other location - About 2 hrs to fix
          core/utility/StringUtility.php on lines 219..243

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 135.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function pluralToSingular($string)
    {
        // save some time in the case that singular and plural are the same
        if (in_array(strtolower($string), $this->uncountable)) {
            return $string;
          Severity: Major
          Found in core/utility/StringUtility.php and 1 other location - About 2 hrs to fix
          core/utility/StringUtility.php on lines 186..210

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 135.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function forgotPasswordForm()
    {
        $page = new Page($this->getRouteInfo()->getAccessRole());
        $page->setTitle('Forgot your password');
          Severity: Major
          Found in components/user/controllers/MemberUserController.php and 1 other location - About 2 hrs to fix
          components/user/controllers/AdminUserController.php on lines 545..572

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 135.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function deleteGroup()
    {
        $inputs = (new Request('POST'))->getInputs();

        if (!empty($inputs['id'])) {
          Severity: Major
          Found in components/user/controllers/MemberGroupController.php and 1 other location - About 2 hrs to fix
          components/contact/controllers/ContactController.php on lines 262..286

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 135.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function forgotPasswordForm()
    {
        $page = new Page($this->getRouteInfo()->getAccessRole());
        $page->setTitle('Forgot your password');
          Severity: Major
          Found in components/user/controllers/AdminUserController.php and 1 other location - About 2 hrs to fix
          components/user/controllers/MemberUserController.php on lines 295..322

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 135.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function deleteMessage()
    {
        $inputs = (new Request('POST'))->getInputs();

        if (!empty($inputs['id'])) {
          Severity: Major
          Found in components/contact/controllers/ContactController.php and 1 other location - About 2 hrs to fix
          components/user/controllers/MemberGroupController.php on lines 260..284

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 135.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File UserAuthentication.php has 278 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
/**
 * Created by PhpStorm.
 * User: ehsanabbasi
 * Date: 24/02/16
          Severity: Minor
          Found in components/user/services/UserAuthentication.php - About 2 hrs to fix

            User has 24 functions (exceeds 20 allowed). Consider refactoring.
            Open

            abstract class User extends BaseModel
{
    protected $name;
    protected $username;
    protected $email;
            Severity: Minor
            Found in components/user/models/User.php - About 2 hrs to fix

              BaseBlock has 24 functions (exceeds 20 allowed). Consider refactoring.
              Open

              abstract class BaseBlock
{
    protected $view;
    protected $config;
    protected $html;
              Severity: Minor
              Found in core/layout/blocks/BaseBlock.php - About 2 hrs to fix

                Method testValidateId has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function testValidateId()
    {
        $app = App::getInstance();
        $app->init('dev');
                Severity: Major
                Found in tests/ValidatorTest.php - About 2 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language