Sign upLogin

iterative/dvc

View on GitHub
Star
dvc/repo/datasets.py

Summary

Maintainability
B
6 hrs
Test Coverage

File datasets.py has 328 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import os
from collections.abc import Iterator, Mapping
from datetime import datetime
from functools import cached_property
from pathlib import Path
Severity: Minor
Found in dvc/repo/datasets.py - About 3 hrs to fix

    Function update has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def update(self, name, **kwargs) -> tuple[Dataset, Dataset]:
        dataset = self[name]
        version = kwargs.get("version")

        if dataset.type == "url" and (version or kwargs.get("rev")):
    Severity: Minor
    Found in dvc/repo/datasets.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def add(
    Severity: Minor
    Found in dvc/repo/datasets.py - About 45 mins to fix

      Function update has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def update(
      Severity: Minor
      Found in dvc/repo/datasets.py - About 35 mins to fix

        Function _build_dataset has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def _build_dataset(
        cls,
        manifest_path: str,
        spec_data: dict[str, Any],
        lock_data: Optional[dict[str, Any]] = None,
        Severity: Minor
        Found in dvc/repo/datasets.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status