iterative/dvc

View on GitHub

Showing 92 of 220 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Severity: Major
Found in dvc/repo/fetch.py and 1 other location - About 5 hrs to fix
dvc/repo/push.py on lines 0..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Severity: Major
Found in dvc/repo/push.py and 1 other location - About 5 hrs to fix
dvc/repo/fetch.py on lines 0..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _do_draw has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    def _do_draw(self, screen):  # pragma: no cover
        # pylint: disable=too-many-locals
        # pylint: disable=too-many-branches, too-many-statements
        from dvc.system import System
        from asciimatics.event import KeyboardEvent
Severity: Minor
Found in dvc/dagascii.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File __init__.py has 343 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from __future__ import unicode_literals

from dvc.utils.compat import str

import os
Severity: Minor
Found in dvc/repo/__init__.py - About 4 hrs to fix

    Function graph has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        def graph(self, stages=None, from_directory=None):
            import networkx as nx
            from dvc.exceptions import (
                OutputDuplicationError,
                WorkingDirectoryAsOutputError,
    Severity: Minor
    Found in dvc/repo/__init__.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

    def add(self, fname, recursive=False, no_commit=False):
        from dvc.stage import Stage
    
        fnames = []
        if recursive and os.path.isdir(fname):
    Severity: Minor
    Found in dvc/repo/add.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __build_graph has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        def __build_graph(self, target, commands, outs):
            import networkx
            from dvc.stage import Stage
    
            stage = Stage.load(self.repo, target)
    Severity: Minor
    Found in dvc/command/pipeline.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function line has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        def line(self, x0, y0, x1, y1, char):
            """Create a line on ASCII canvas.
    
            Args:
                x0 (int): x coordinate where the line should start.
    Severity: Minor
    Found in dvc/dagascii.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function run has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        def run(self, dry=False, resume=False, no_commit=False):
            if self.locked:
                logger.info(
                    "Verifying outputs in locked stage '{stage}'".format(
                        stage=self.relpath
    Severity: Minor
    Found in dvc/stage.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function stages has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        def stages(self, from_directory=None, check_dag=True):
            """
            Walks down the root directory looking for Dvcfiles,
            skipping the directories that are related with
            any SCM (e.g. `.git`), DVC itself (`.dvc`), or directories
    Severity: Minor
    Found in dvc/repo/__init__.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File data_sync.py has 275 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    from __future__ import unicode_literals
    
    import argparse
    
    import dvc.logger as logger
    Severity: Minor
    Found in dvc/command/data_sync.py - About 2 hrs to fix

      Function reproduce has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

      def reproduce(
          self,
          target=None,
          recursive=True,
          force=False,
      Severity: Minor
      Found in dvc/repo/reproduce.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function used_cache has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          def used_cache(
              self,
              target=None,
              all_branches=False,
              active=True,
      Severity: Minor
      Found in dvc/repo/__init__.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function download has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          def download(
              self,
              from_infos,
              to_infos,
              no_progress_bar=False,
      Severity: Minor
      Found in dvc/remote/s3.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function gc has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      def gc(
          self,
          all_branches=False,
          cloud=False,
          remote=None,
      Severity: Minor
      Found in dvc/repo/gc.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function save has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def save(self):
              if not os.path.exists(self.path):
                  raise self.DoesNotExistError(self.rel_path)
      
              if not os.path.isfile(self.path) and not os.path.isdir(self.path):
      Severity: Minor
      Found in dvc/output/local.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function download has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def download(
              self,
              from_infos,
              to_infos,
              no_progress_bar=False,
      Severity: Minor
      Found in dvc/remote/gs.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function download has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def download(
              self,
              from_infos,
              to_infos,
              no_progress_bar=False,
      Severity: Minor
      Found in dvc/remote/azure.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _exec has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def _exec(self, ssh, cmd):
              stdin, stdout, stderr = ssh.exec_command(cmd)
              channel = stdout.channel
      
              stdin.close()
      Severity: Minor
      Found in dvc/remote/ssh.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function run has 14 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def run(
      Severity: Major
      Found in dvc/repo/run.py - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language