Sign upLogin

iterative/dvc

View on GitHub
Star
dvc/repo/diff.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function _diff has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

def _diff(old, new, data_keys, with_missing=False):
    from dvc_data.index.diff import ADD, DELETE, MODIFY, RENAME
    from dvc_data.index.diff import diff as idiff

    ret: "dict[str, list[dict]]" = {
Severity: Minor
Found in dvc/repo/diff.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function diff has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Wontfix

def diff(
    self,
    a_rev: str = "HEAD",
    b_rev: Optional[str] = None,
    targets: Optional[list[str]] = None,
Severity: Minor
Found in dvc/repo/diff.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if (change.old and change.old.isdir and not change.old.hash_info) or (
            change.new and change.new.isdir and not change.new.hash_info
        ):
            continue
Severity: Major
Found in dvc/repo/diff.py - About 40 mins to fix

    Function diff has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def diff(
    Severity: Minor
    Found in dvc/repo/diff.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status