iterative/vscode-dvc

View on GitHub
extension/src/experiments/workspace.ts

Summary

Maintainability
C
1 day
Test Coverage
B
82%

File workspace.ts has 356 lines of code (exceeds 300 allowed). Consider refactoring.
Open

import { EventEmitter } from 'vscode'
import isEmpty from 'lodash.isempty'
import { Experiments } from '.'
import {
  getBranchExperimentCommand,
Severity: Minor
Found in extension/src/experiments/workspace.ts - About 3 hrs to fix

    WorkspaceExperiments has 33 functions (exceeds 30 allowed). Consider refactoring.
    Open

    export class WorkspaceExperiments extends BaseWorkspaceWebviews<
      Experiments,
      TableData
    > {
      public readonly experimentsChanged = this.dispose.track(
    Severity: Minor
    Found in extension/src/experiments/workspace.ts - About 2 hrs to fix

      Function createRepository has 50 lines of code (exceeds 40 allowed). Consider refactoring.
      Open

        public createRepository(
          dvcRoot: string,
          subProjects: string[],
          pipeline: WorkspacePipeline,
          setup: Setup,
      Severity: Minor
      Found in extension/src/experiments/workspace.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          public async modifyWorkspaceParamsAndRun(overrideRoot?: string) {
            const project = await this.getDvcRoot(overrideRoot)
            if (!project) {
              return
            }
        Severity: Major
        Found in extension/src/experiments/workspace.ts and 1 other location - About 2 hrs to fix
        extension/src/experiments/workspace.ts on lines 138..149

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          public async modifyWorkspaceParamsAndQueue(overrideRoot?: string) {
            const project = await this.getDvcRoot(overrideRoot)
            if (!project) {
              return
            }
        Severity: Major
        Found in extension/src/experiments/workspace.ts and 1 other location - About 2 hrs to fix
        extension/src/experiments/workspace.ts on lines 125..136

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status