Sign upLogin

iterative/vscode-dvc

View on GitHub
Star
extension/src/plots/webview/messages.ts

Summary

Maintainability
D
2 days
Test Coverage
A
94%

File messages.ts has 477 lines of code (exceeds 300 allowed). Consider refactoring.
Open

import { join } from 'path'
import { commands } from 'vscode'
import isEmpty from 'lodash.isempty'
import {
  ComparisonPlot,
Severity: Minor
Found in extension/src/plots/webview/messages.ts - About 6 hrs to fix

    WebviewMessages has 32 functions (exceeds 30 allowed). Consider refactoring.
    Open

    export class WebviewMessages {
  private readonly dvcRoot: string
  private readonly paths: PathsModel
  private readonly plots: PlotsModel
  private readonly errors: ErrorsModel
    Severity: Minor
    Found in extension/src/plots/webview/messages.ts - About 2 hrs to fix

      Function handleMessageFromWebview has 72 lines of code (exceeds 40 allowed). Consider refactoring.
      Open

        public handleMessageFromWebview(message: MessageFromWebview) {
    switch (message.type) {
      case MessageFromWebviewType.ADD_PLOT:
        return commands.executeCommand(
          RegisteredCommands.ADD_PLOT,
      Severity: Major
      Found in extension/src/plots/webview/messages.ts - About 2 hrs to fix

        Function getWebviewData has 43 lines of code (exceeds 40 allowed). Consider refactoring.
        Open

          private async getWebviewData(): Promise<TPlotsData> {
    const selectedRevisions = this.plots.getSelectedRevisionDetails()

    const [
      cliError,
        Severity: Minor
        Found in extension/src/plots/webview/messages.ts - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            private exportPlotDataAsCsv(plotId: string) {
    void this.exportPlotData(
      'csv',
      plotId,
      EventName.VIEWS_PLOTS_EXPORT_PLOT_DATA_AS_CSV,
          Severity: Major
          Found in extension/src/plots/webview/messages.ts and 2 other locations - About 1 hr to fix
          extension/src/plots/webview/messages.ts on lines 491..499
          extension/src/plots/webview/messages.ts on lines 511..519

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            private exportPlotDataAsTsv(plotId: string) {
    void this.exportPlotData(
      'tsv',
      plotId,
      EventName.VIEWS_PLOTS_EXPORT_PLOT_DATA_AS_TSV,
          Severity: Major
          Found in extension/src/plots/webview/messages.ts and 2 other locations - About 1 hr to fix
          extension/src/plots/webview/messages.ts on lines 491..499
          extension/src/plots/webview/messages.ts on lines 501..509

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            private exportPlotDataAsJson(plotId: string) {
    void this.exportPlotData(
      'json',
      plotId,
      EventName.VIEWS_PLOTS_EXPORT_PLOT_DATA_AS_JSON,
          Severity: Major
          Found in extension/src/plots/webview/messages.ts and 2 other locations - About 1 hr to fix
          extension/src/plots/webview/messages.ts on lines 501..509
          extension/src/plots/webview/messages.ts on lines 511..519

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            private setComparisonOrder(order: string[]) {
    this.plots.setComparisonOrder(order)
    this.sendComparisonPlots()
    sendTelemetryEvent(
      EventName.VIEWS_PLOTS_REVISIONS_REORDERED,
          Severity: Minor
          Found in extension/src/plots/webview/messages.ts and 1 other location - About 55 mins to fix
          extension/src/plots/webview/messages.ts on lines 262..270

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            private setComparisonRowsOrder(order: string[]) {
    this.paths.setComparisonPathsOrder(order)
    this.sendComparisonPlots()
    sendTelemetryEvent(
      EventName.VIEWS_PLOTS_COMPARISON_ROWS_REORDERED,
          Severity: Minor
          Found in extension/src/plots/webview/messages.ts and 1 other location - About 55 mins to fix
          extension/src/plots/webview/messages.ts on lines 252..260

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                case MessageFromWebviewType.SET_COMPARISON_MULTI_PLOT_VALUE:
        return this.setComparisonMultiPlotValue(
          message.payload.revision,
          message.payload.path,
          message.payload.value
          Severity: Minor
          Found in extension/src/plots/webview/messages.ts and 1 other location - About 30 mins to fix
          extension/src/plots/webview/messages.ts on lines 94..99

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                case MessageFromWebviewType.RESIZE_PLOTS:
        return this.setPlotSize(
          message.payload.section,
          message.payload.nbItemsPerRow,
          message.payload.height
          Severity: Minor
          Found in extension/src/plots/webview/messages.ts and 1 other location - About 30 mins to fix
          extension/src/plots/webview/messages.ts on lines 114..119

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status