iterative/vscode-dvc

View on GitHub
webview/src/experiments/components/table/Indicators.tsx

Summary

Maintainability
C
1 day
Test Coverage
A
100%

Function Indicators has 82 lines of code (exceeds 40 allowed). Consider refactoring.
Open

export const Indicators = () => {
  const filters = useSelector(
    (state: ExperimentsState) => state.tableData.filters
  )
  const filtersCount = filters?.length
Severity: Major
Found in webview/src/experiments/components/table/Indicators.tsx - About 2 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          <Indicator
            count={sortsCount}
            aria-label="sorts"
            onClick={focusSortsTree}
            tooltipContent="Show Sorts"
    Severity: Major
    Found in webview/src/experiments/components/table/Indicators.tsx and 3 other locations - About 1 hr to fix
    webview/src/experiments/components/table/Indicators.tsx on lines 72..79
    webview/src/experiments/components/table/Indicators.tsx on lines 89..96
    webview/src/experiments/components/table/Indicators.tsx on lines 105..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          <Indicator
            count={columnsSelected}
            aria-label="columns"
            onClick={selectColumns}
            tooltipContent="Select Columns"
    Severity: Major
    Found in webview/src/experiments/components/table/Indicators.tsx and 3 other locations - About 1 hr to fix
    webview/src/experiments/components/table/Indicators.tsx on lines 89..96
    webview/src/experiments/components/table/Indicators.tsx on lines 97..104
    webview/src/experiments/components/table/Indicators.tsx on lines 105..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          <Indicator
            count={filtersCount}
            aria-label="filters"
            onClick={focusFiltersTree}
            tooltipContent="Show Filters"
    Severity: Major
    Found in webview/src/experiments/components/table/Indicators.tsx and 3 other locations - About 1 hr to fix
    webview/src/experiments/components/table/Indicators.tsx on lines 72..79
    webview/src/experiments/components/table/Indicators.tsx on lines 97..104
    webview/src/experiments/components/table/Indicators.tsx on lines 105..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          <Indicator
            count={selectedForPlotsCount}
            aria-label="selected for plots"
            onClick={openPlotsWebview}
            tooltipContent="Show Plots"
    Severity: Major
    Found in webview/src/experiments/components/table/Indicators.tsx and 3 other locations - About 1 hr to fix
    webview/src/experiments/components/table/Indicators.tsx on lines 72..79
    webview/src/experiments/components/table/Indicators.tsx on lines 89..96
    webview/src/experiments/components/table/Indicators.tsx on lines 97..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status