jacobemerick/web

View on GitHub
module/form/CommentSubmitModule.class.inc.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Method save has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function save(array $data)
    {
        $path = $_SERVER['REQUEST_URI'];
        $path = explode('/', $path);
        $path = array_filter($path);
Severity: Minor
Found in module/form/CommentSubmitModule.class.inc.php - About 1 hr to fix

    Function checkValidation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function checkValidation()
        {
            $errors = array();
            if (!Validate::checkRequest('post', 'name', 'name')) {
                $errors['name'] = 'You must include a valid name';
    Severity: Minor
    Found in module/form/CommentSubmitModule.class.inc.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return [
                    'service' => 'There was a problem saving your comment. Please try again.',
                ];
    Severity: Major
    Found in module/form/CommentSubmitModule.class.inc.php - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status