Sign upLogin

jacobemerick/web

View on GitHub
Star
router/WaterfallRouter.class.inc.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Method get_direct_array has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function get_direct_array()
    {
        return array(
            (object) array(
                'match' => '/',
Severity: Major
Found in router/WaterfallRouter.class.inc.php - About 2 hrs to fix

    Method get_redirect_array has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_redirect_array()
    {
        return array(
            (object) array(
                'pattern' => '@/index.(html|htm|php)$@',
    Severity: Major
    Found in router/WaterfallRouter.class.inc.php - About 2 hrs to fix

      Function check_for_special_redirect has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function check_for_special_redirect($uri)
    {
        if (preg_match('@^/falls/([a-z\'-]+)(/?)$@', $uri, $matches)) {
            $alias = $matches[1];
            $alias = str_replace("'", '', $alias);
      Severity: Minor
      Found in router/WaterfallRouter.class.inc.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_for_special_redirect has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function check_for_special_redirect($uri)
    {
        if (preg_match('@^/falls/([a-z\'-]+)(/?)$@', $uri, $matches)) {
            $alias = $matches[1];
            $alias = str_replace("'", '', $alias);
      Severity: Minor
      Found in router/WaterfallRouter.class.inc.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                return $uri;
        Severity: Major
        Found in router/WaterfallRouter.class.inc.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status