lib/oakdex/battle/active_in_battle_pokemon.rb
Class ActiveInBattlePokemon
has 24 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class ActiveInBattlePokemon
extend Forwardable
def_delegators :@pokemon, :moves_with_pp, :fainted?, :id
def_delegators :@side, :battle
Method targets_in_battle
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def targets_in_battle(move)
available_targets(move).map do |targets|
if targets.last.is_a?(Array)
targets if targets_in_battle?(targets)
elsif target_in_battle?(targets)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"