Sign upLogin

jaroslavtyc/drd-plus-codes

View on GitHub
Star

Showing 591 of 591 total issues

Avoid using static access to class '\DrdPlus\Codes\Properties\RemarkableSenseCode' in method 'I_can_get_remarkable_property_codes'.
Open

            RemarkableSenseCode::getPossibleValues(),
Severity: Minor
Found in tests/Codes/Properties/PropertyCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\Properties\PropertyCode' in method 'I_can_get_restriction_property_codes'.
Open

            PropertyCode::getRestrictionPropertyPossibleValues()
Severity: Minor
Found in tests/Codes/Properties/PropertyCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\RaceCode' in method 'I_can_easily_find_out_if_sub_race_belongs_to_race'.
Open

                    $otherRaceCode = RaceCode::getIt($otherRace);
Severity: Minor
Found in tests/Codes/SubRaceCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\SubRaceCode' in method 'I_can_get_races_to_sub_races_codes'.
Open

            SubRaceCode::getPossibleValues(),
Severity: Minor
Found in tests/Codes/SubRaceCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\SubRaceCode' in method 'I_can_get_races_to_sub_races_codes'.
Open

        self::assertEquals(RaceCode::getPossibleValues(), array_keys(SubRaceCode::getRaceToSubRaceValues()));
Severity: Minor
Found in tests/Codes/SubRaceCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\Theurgist\ProfileCode' in method 'I_can_ask_it_for_gender_and_get_opposite'.
Open

        $lookMars = ProfileCode::getIt(ProfileCode::LOOK_MARS);
Severity: Minor
Found in tests/Codes/Theurgist/ProfileCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\Skills\SkillTypeCode' in method 'I_can_get_all_codes_at_once_or_by_same_named_constant'.
Open

            SkillTypeCode::getPossibleValues()
Severity: Minor
Found in tests/Codes/Skills/SkillTypeCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\SubRaceCode' in method 'I_can_get_races_to_sub_races_codes'.
Open

            array_merge(array_unique($this->toFlatValues(SubRaceCode::getRaceToSubRaceValues())))
Severity: Minor
Found in tests/Codes/SubRaceCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\Transport\RidingAnimalMovementCode' in method 'I_can_get_movements_without_jump'.
Open

        $allValues = RidingAnimalMovementCode::getPossibleValues();
Severity: Minor
Found in tests/Codes/Transport/RidingAnimalMovementCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\Partials\TranslatableExtendableCode' in method 'It_uses_parent_values_as_default_if_not_overloaded'.
Open

        self::assertSame([], TranslatableExtendableCode::getPossibleValues());
Severity: Minor
Found in tests/Codes/Partials/TranslatableExtendableCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method I_get_whispered_current_code_as_return_value_of_factory_method uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                self::assertStringContainsString(<<<PHPDOC
 * @return {$classBaseName}|AbstractCode
PHPDOC
                    , preg_replace('~ +~', ' ', $reflectionClass->getMethod('findIt')->getDocComment()),
Severity: Minor
Found in tests/Codes/AllCodesTest.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\DrdPlus\Codes\Properties\PropertyCode' in method 'I_can_get_base_property_codes'.
Open

            PropertyCode::getBasePropertyPossibleValues()
Severity: Minor
Found in tests/Codes/Properties/PropertyCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'DrdPlus\Codes\Armaments\MeleeWeaponCode' in method 'convertToMeleeWeaponCodeEquivalent'.
Open

        return MeleeWeaponCode::getIt($this->getValue());
Severity: Minor
Found in Codes/Armaments/RangedWeaponCode.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method I_get_whispered_current_code_as_return_value_of_factory_method uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                self::assertStringContainsString(<<<PHPDOC
 * @return {$classBaseName}|AbstractCode
PHPDOC
                    , preg_replace('~ +~', ' ', $reflectionClass->getMethod('getIt')->getDocComment()),
Severity: Minor
Found in tests/Codes/AllCodesTest.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method fetchTranslations() has 123 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    protected function fetchTranslations(): array
    {
        return [
            'en' => [
                self::LIGHT_AXE => [self::$ONE => 'light axe', self::$FEW => 'light axes', self::$MANY => 'light axes'],
Severity: Minor
Found in Codes/Armaments/MeleeWeaponCode.php by phpmd

Avoid using static access to class '\DrdPlus\Codes\Properties\PropertyCode' in method 'I_can_get_derived_property_codes'.
Open

            PropertyCode::getDerivedPropertyPossibleValues()
Severity: Minor
Found in tests/Codes/Properties/PropertyCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\ItemHoldingCode' in method 'I_can_ask_it_which_holding_easily'.
Open

        $itemHolding = ItemHoldingCode::getIt($holdingValue);
Severity: Minor
Found in tests/Codes/ItemHoldingCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'DrdPlus\Codes\Armaments\WeaponCategoryCode' in method 'guardSameCategory'.
Open

            foreach (WeaponCategoryCode::getPossibleValues() as $anotherCategory) {
Severity: Minor
Found in Codes/Armaments/MeleeWeaponCode.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\Partials\AbstractCode' in method 'I_will_get_constant_values_from_reflection_as_fallback'.
Open

        self::assertSame([], AbstractCode::getPossibleValues());
Severity: Minor
Found in tests/Codes/AbstractCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\SubRaceCode' in method 'I_can_easily_find_out_if_sub_race_belongs_to_race'.
Open

                $subRaceCode = SubRaceCode::getIt($subRace);
Severity: Minor
Found in tests/Codes/SubRaceCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language