Sign upLogin

jaroslavtyc/drd-plus-codes

View on GitHub
Star

Showing 591 of 591 total issues

The method I_can_easily_find_out_if_is_melee_weapon is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_melee_weapon()
    {
        self::assertFalse(ShieldCode::getIt(ShieldCode::BUCKLER)->isMeleeWeapon());
    }
Severity: Minor
Found in tests/Codes/Armaments/ShieldCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method It_is_weapon_code is not named in camelCase.
Open

    public function It_is_weapon_code()
    {
        /** @var WeaponCode $sut */
        $sut = $this->getSut();
        self::assertInstanceOf(WeaponCode::class, $sut);
Severity: Minor
Found in tests/Codes/Armaments/WeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Has_unique_codes_across_all_weaponlikes is not named in camelCase.
Open

    public function Has_unique_codes_across_all_weaponlikes()
    {
        $sutClass = self::getSutClass();
        $reflection = new \ReflectionClass($sutClass);
        $sameCodes = [];
Severity: Minor
Found in tests/Codes/Armaments/WeaponlikeCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method It_is_weaponlike_code is not named in camelCase.
Open

    public function It_is_weaponlike_code()
    {
        $reflection = new \ReflectionClass(self::getSutClass());
        /** @var WeaponlikeCode $sut */
        $sut = $reflection->newInstanceWithoutConstructor();
Severity: Minor
Found in tests/Codes/Armaments/WeaponlikeCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_is_dart is not named in camelCase.
Open

    public function I_can_find_out_if_is_dart()
    {
        self::assertFalse(SlingStoneCode::getIt(SlingStoneCode::SLING_STONE_LIGHT)->isDart());
    }
Severity: Minor
Found in tests/Codes/Armaments/SlingStoneCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_ranged is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_ranged()
    {
        self::assertFalse(ShieldCode::getIt(ShieldCode::WITHOUT_SHIELD)->isRanged());
    }
Severity: Minor
Found in tests/Codes/Armaments/ShieldCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_projectile_category_codes is not named in camelCase.
Open

    public function I_can_get_projectile_category_codes()
    {
        self::assertSame(
            $codes = ['arrows', 'darts', 'sling_stones'],
            WeaponCategoryCode::getProjectileCategoryValues()
Severity: Minor
Found in tests/Codes/Armaments/WeaponCategoryCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_shield is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_shield()
    {
        /** @var WeaponCode $sut */
        $sut = $this->getSut();
        self::assertFalse($sut->isShield());
Severity: Minor
Found in tests/Codes/Armaments/WeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_use_invalid_data_format_of_translations_for_custom_code is not named in camelCase.
Open

    public function I_can_not_use_invalid_data_format_of_translations_for_custom_code()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\InvalidTranslationFormat::class);
        $this->expectExceptionMessageMatches('~this should be array~');
        /** like @see \DrdPlus\Codes\Armaments\MeleeWeaponCode::addNewMeleeWeaponCode */
Severity: Minor
Found in tests/Codes/Armaments/WeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_weapon_is_unarmed_in_fact is not named in camelCase.
Open

    abstract public function I_can_easily_find_out_if_weapon_is_unarmed_in_fact();
Severity: Minor
Found in tests/Codes/Armaments/WeaponlikeCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_ask_it_if_is_mechanical is not named in camelCase.
Open

    public function I_can_ask_it_if_is_mechanical(string $origin, bool $isPsychical, bool $isElemental, bool $isMechanical)
    {
        $seriousWoundOriginCode = SeriousWoundOriginCode::getIt($origin);
        self::assertSame($origin, $seriousWoundOriginCode->getValue());
        self::assertSame($isPsychical, $seriousWoundOriginCode->isPsychical());
Severity: Minor
Found in tests/Codes/Body/SeriousWoundOriginCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language