Sign upLogin

jaroslavtyc/drd-plus-health

View on GitHub
Star

Showing 669 of 669 total issues

Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Thirst' in method 'I_can_get_malus_to_activities'.
Open

        $thirst = Thirst::createIt(new Health(), AfflictionSize::getIt(567));
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\AfflictionSize' in method 'I_can_get_knack_malus'.
Open

        $thirst = Thirst::createIt(new Health(), AfflictionSize::getIt(567));
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Thirst' in method 'I_can_get_will_malus'.
Open

        $thirst = Thirst::createIt(new Health(), AfflictionSize::getIt(567));
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\AfflictionSize' in method 'I_can_get_charisma_malus'.
Open

        $thirst = Thirst::createIt(new Health(), AfflictionSize::getIt(567));
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\ElementalPertinence\EarthPertinence' in method 'createIt'.
Open

            EarthPertinence::getMinus(),
Severity: Minor
Found in Health/Afflictions/SpecificAfflictions/SeveredArm.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Cold' in method 'I_can_get_knack_malus'.
Open

        $cold = Cold::createIt($wound);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ColdTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\AfflictionDangerousness' in method 'createIt'.
Open

            AfflictionDangerousness::getIt(9999), // irrelevant, full deformation can not be avoided
Severity: Minor
Found in Health/Afflictions/SpecificAfflictions/SeveredArm.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\AfflictionVirulence' in method 'createIt'.
Open

            AfflictionVirulence::getDayVirulence(),
Severity: Minor
Found in Health/Afflictions/SpecificAfflictions/SeveredArm.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\Effects\SeveredArmEffect' in method 'createIt'.
Open

            SeveredArmEffect::getIt(),
Severity: Minor
Found in Health/Afflictions/SpecificAfflictions/SeveredArm.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method I_can_get_every_source uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            self::assertFalse($source->isDeformation(), "Expected source {$source} to be a deformation");
        }
Severity: Minor
Found in tests/Health/Afflictions/AfflictionSourceTest.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\DrdPlus\Health\Afflictions\AfflictionVirulence' in method 'I_can_get_every_virulence'.
Open

        $roundVirulence = AfflictionVirulence::getRoundVirulence();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionVirulenceTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\Effects\CrackedBonesEffect' in method 'I_can_find_out_if_apply_even_on_success_against_trap'.
Open

        $crackedBonesEffect = CrackedBonesEffect::getIt();
Severity: Minor
Found in tests/Health/Afflictions/Effects/CrackedBonesEffectTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\Effects\ThirstEffect' in method 'I_can_find_out_if_apply_even_on_success_against_trap'.
Open

        $thirstEffect = ThirstEffect::getIt();
Severity: Minor
Found in tests/Health/Afflictions/Effects/ThirstEffectTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Bleeding' in method 'I_can_get_agility_malus'.
Open

        $bleeding = Bleeding::createIt($wound, $woundBoundary);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/BleedingTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Cold' in method 'I_can_get_agility_malus'.
Open

        $cold = Cold::createIt($wound);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ColdTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused local variables such as '$filledHalfOfRows'.
Open

        $this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/CrackedBonesTest.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$filledHalfOfRows'.
Open

        $this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/CrackedBonesTest.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$filledHalfOfRows'.
Open

        $this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/CrackedBonesTest.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Thirst' in method 'getSut'.
Open

        return Thirst::createIt(new Health(), AfflictionSize::getIt(46));
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Thirst' in method 'I_can_get_strength_malus'.
Open

        $thirst = Thirst::createIt(new Health(), AfflictionSize::getIt(567));
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language