Sign upLogin

jaroslavtyc/drd-plus-health

View on GitHub
Star

Showing 669 of 669 total issues

The method I_can_use_wound_reason is not named in camelCase.
Open

    public function I_can_use_wound_reason(): void
    {
        $woundReason = ReasonToRollAgainstMalusFromWounds::getWoundReason();
        self::assertTrue($woundReason->becauseOfWound());
        self::assertFalse($woundReason->becauseOfHeal());
Severity: Minor
Found in tests/Health/ReasonToRollAgainstMalusTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_create_treatment_boundary is not named in camelCase.
Open

    public function I_can_create_treatment_boundary(): void
    {
        $treatmentBoundary = TreatmentBoundary::getIt($value = 0);
        self::assertSame($value, $treatmentBoundary->getValue());
    }
Severity: Minor
Found in tests/Health/TreatmentBoundaryTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_create_it_without_glare_at_all is not named in camelCase.
Open

    public function I_can_create_it_without_glare_at_all(): void
    {
        $glared = Glared::createWithoutGlare($health = new Health());
        self::assertSame(0, $glared->getCurrentMalus());
        self::assertSame($health, $glared->getHealth());
Severity: Minor
Found in tests/Health/Inflictions/GlaredTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it(): void
    {
        $pointOfWound = new PointOfWound($wound = $this->createWound());
        self::assertSame(1, $pointOfWound->getValue());
        self::assertSame($wound, $pointOfWound->getWound());
Severity: Minor
Found in tests/Health/PointOfWoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_am_stopped_by_specific_exception_on_invalid_value is not named in camelCase.
Open

    public function I_am_stopped_by_specific_exception_on_invalid_value(): void
    {
        $this->expectException(\Granam\Integer\Tools\Exceptions\WrongParameterType::class);
        $this->expectExceptionMessageMatches('~Terribly wounded by horrible pebble~');
        new WoundSize('Terribly wounded by horrible pebble');
Severity: Minor
Found in tests/Health/WoundSizeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_create_wound_with_zero_value is not named in camelCase.
Open

    public function I_can_create_wound_with_zero_value(): void
    {
        $wound = $this->createWound(
            $this->createHealth(),
            new WoundSize(0),
Severity: Minor
Found in tests/Health/WoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_used_to_darkness_by_very_long_waiting_when_shined is not named in camelCase.
Open

    public function I_can_get_used_to_darkness_by_very_long_waiting_when_shined(): void
    {
        $shined = Glared::createFromGlare($this->createGlare($malus = -1, true /* shined = not blinded */), new Health());

        self::assertSame($malus, $shined->getCurrentMalus());
Severity: Minor
Found in tests/Health/Inflictions/GlaredTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_used_to_shine_by_long_waiting is not named in camelCase.
Open

    public function I_can_get_used_to_shine_by_long_waiting(): void
    {
        $glared = Glared::createFromGlare($this->createGlare(-50, true), new Health());

        self::assertSame(-50, $glared->getCurrentMalus());
Severity: Minor
Found in tests/Health/Inflictions/GlaredTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_worse_malus_than_minus_three is not named in camelCase.
Open

    public function I_can_not_create_worse_malus_than_minus_three()
    {
        $this->expectException(\DrdPlus\Health\Exceptions\UnexpectedMalusValue::class);
        $this->expectExceptionMessageMatches('~-4~');
        MalusFromWounds::getIt(-4);
Severity: Minor
Found in tests/Health/MalusFromWoundsTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language