Sign upLogin

jaroslavtyc/drd-plus-rolls-on

View on GitHub
Star

Showing 105 of 105 total issues

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it($difficulty, RollOnQuality $rollOnQuality, $shouldSuccess)
    {
        $basicRollOnSuccess = new BasicRollOnSuccess($difficulty, $rollOnQuality);

        self::assertInstanceOf(BooleanInterface::class, $basicRollOnSuccess);
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/BasicRollOnSuccessTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_failed_just_moderately is not named in camelCase.
Open

    public function I_can_find_out_if_failed_just_moderately(
        $roll,
        $defiance,
        $ride,
        $ridingSkill,
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/RollOnAnimalControlTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_affect_it_by_bonus_from_used_remarkable_sense is not named in camelCase.
Open

    public function I_can_affect_it_by_bonus_from_used_remarkable_sense()
    {
        $rollOnSenses = new RollOnSenses(
            $senses = $this->createSenses(123),
            $roll2D6DrdPlus = $this->createRoll2d6DrdPlus(456),
Severity: Minor
Found in tests/RollsOn/Traps/RollOnSensesTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_make_basic_roll_on_success is not named in camelCase.
Open

    public function I_can_make_basic_roll_on_success()
    {
        $rollsOn = new RollsOnFactory($this->createRoller2d6DrdPlus());

        $basicRollOnSuccess = $rollsOn->makeBasicRollOnSuccess(
Severity: Minor
Found in tests/RollsOn/RollsOnFactoryTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_only_unique_success_codes is not named in camelCase.
Open

    public function I_can_use_only_unique_success_codes()
    {
        $this->expectException(\DrdPlus\RollsOn\QualityAndSuccess\Exceptions\EverySuccessCodeShouldBeUnique::class);
        $rollOnQuality = $this->createRollOnQuality(1);
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/ExtendedRollOnSuccessTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_failed_fatally is not named in camelCase.
Open

    public function I_can_find_out_if_failed_fatally($roll, $defiance, $ride, $ridingSkill, $previousFailuresCount, $isFatalFailure)
    {
        $rollOnAnimalControl = new RollOnAnimalControl(
            $this->createRollOnAgility($roll),
            $this->createAnimalDefiance($defiance),
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/RollOnAnimalControlTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_create_it_only_from_simple_rolls_on_success is not named in camelCase.
Open

    public function I_can_create_it_only_from_simple_rolls_on_success()
    {
        $this->expectException(\DrdPlus\RollsOn\QualityAndSuccess\Exceptions\ExpectedSimpleRollsOnSuccessOnly::class);
        $rollOnQuality = $this->createRollOnQuality(123);
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/ExtendedRollOnSuccessTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_make_malus_roll_on_will is not named in camelCase.
Open

    public function I_can_make_malus_roll_on_will($rollValue, $willValue, $expectedMalus)
    {
        $rollsOnFactory = new RollsOnFactory($this->createRoller2d6DrdPlus($rollValue));

        $malusRollOnWill = $rollsOnFactory->makeMalusRollOnWill(Will::getIt($willValue));
Severity: Minor
Found in tests/RollsOn/RollsOnFactoryTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    abstract public function I_can_use_it();
Severity: Minor
Found in tests/RollsOn/Situations/RollOnSituationTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it($compareThatValue, $withThatValue, $firstIsLesser, $firstIsGreater)
    {
        $compareThat = $this->createRollOnQuality($compareThatValue);
        $withThat = $this->createRollOnQuality($withThatValue);
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/ComparisonOfRollsOnQualityTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $rollOnQuality = new RollOnQuality($preconditionsSum = 12345, $roll = $this->createRoll($rollValue = 56789));
        self::assertSame($preconditionsSum, $rollOnQuality->getPreconditionsSum());
        self::assertSame($roll, $rollOnQuality->getRoll());
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/RollOnQualityTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_make_roll_on_quality is not named in camelCase.
Open

    public function I_can_make_roll_on_quality()
    {
        $rollsOn = new RollsOnFactory($this->createRoller2d6DrdPlus());

        $rollOnQuality = $rollsOn->makeRollOnQuality(
Severity: Minor
Found in tests/RollsOn/RollsOnFactoryTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $successfulRollOn = new SimpleRollOnSuccess(
            $difficulty = 123,
            $rollOnQuality = new RollOnQuality($preconditions = 456, $this->createRoll($rollValue = 789))
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/SimpleRollOnSuccessTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_make_roll_on_fight is not named in camelCase.
Open

    public function I_can_make_roll_on_fight(): void
    {
        $rollsOn = new RollsOnFactory($roller = $this->createRoller2d6DrdPlus($rollValue = 123));
        $rollOnFight = $rollsOn->makeRollOnFight($fightNumber = 55667788);
        self::assertSame($fightNumber, $rollOnFight->getFightNumber());
Severity: Minor
Found in tests/RollsOn/RollsOnFactoryTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it($value, $expectedMalus, $isSuccess)
    {
        $malusRollOnWillBecauseOfWounds = new RollOnWillAgainstMalus(
            $rollOnWill = $this->createRollOnWill($value)
        );
Severity: Minor
Found in tests/RollsOn/Traps/RollOnWillAgainstMalusTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it(RollOnQuality $expectedRollOnQuality, array $simpleRollsOnSuccess, string $expectedResultCode, bool $expectingSuccess)
    {
        $extendedRollOnSuccessReflection = new \ReflectionClass(ExtendedRollOnSuccess::class);
        /** @var ExtendedRollOnSuccess $extendedRollOnSuccess */
        $extendedRollOnSuccess = $extendedRollOnSuccessReflection->newInstanceArgs($simpleRollsOnSuccess);
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/ExtendedRollOnSuccessTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $rollOnAnimalControl = new RollOnAnimalControl(
            $rollOnAgility = $this->createRollOnAgility(321),
            $this->createAnimalDefiance(123),
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/RollOnAnimalControlTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_only_unique_difficulties is not named in camelCase.
Open

    public function I_can_use_only_unique_difficulties()
    {
        $this->expectException(\DrdPlus\RollsOn\QualityAndSuccess\Exceptions\EveryDifficultyShouldBeUnique::class);
        $rollOnQuality = $this->createRollOnQuality(123);
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/ExtendedRollOnSuccessTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $rollOnFight = new RollOnFight($fightNumber = 123, $roll2d6DrdPlus = $this->createRoll2d6DrdPlus($rollValue = 456));
        self::assertSame($fightNumber, $rollOnFight->getFightNumber());
        self::assertSame($roll2d6DrdPlus, $rollOnFight->getRoll2d6Plus());
Severity: Minor
Found in tests/RollsOn/Situations/RollOnFightTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it($compareThatValue, $withThatValue, $firstIsLesser, $firstIsGreater)
    {
        $compareThat = $this->createRollOnSuccessWithQuality($compareThatValue);
        $withThat = $this->createRollOnSuccessWithQuality($withThatValue);
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/ComparisonOfRollsOnSuccessTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language