Sign upLogin

jaroslavtyc/drd-plus-rolls-on

View on GitHub
Star

Showing 105 of 105 total issues

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        /** @var ShortRollOnProperty $sutClass */
        $sutClass = self::getSutClass();
        /** @var ShortRollOnProperty $shortRollOnProperty */
Severity: Minor
Found in tests/RollsOn/Traps/ShortRollOnPropertyTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_fail_and_succeed is not named in camelCase.
Open

    public function I_can_fail_and_succeed(ShortRollOnIntelligence $shortRollOnIntelligence, $difficulty, $isSuccess, $expectedResult)
    {
        $rollOnKnowledge = new RollOnKnowledge($shortRollOnIntelligence, $difficulty);
        self::assertInstanceOf(ExtendedRollOnSuccess::class, $rollOnKnowledge);
        self::assertSame($isSuccess, $rollOnKnowledge->isSuccess());
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/RollOnKnowledgeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $zeroBonusFromUsedRemarkableSense = new BonusFromUsedRemarkableSense(
            $raceCode = $this->createRaceCode('foo'),
            $subRaceCode = $this->createSubRaceCode('bar'),
Severity: Minor
Found in tests/RollsOn/Traps/BonusFromUsedRemarkableSenseTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_non_unique_success_codes_if_no_success_happens_on_them is not named in camelCase.
Open

    public function I_can_use_non_unique_success_codes_if_no_success_happens_on_them()
    {
        $rollOnQuality = $this->createRollOnQuality(1);

        $extendedRollOnSuccess = new ExtendedRollOnSuccess(
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/ExtendedRollOnSuccessTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_different_instances_with_same_values_of_rolls_on_quality is not named in camelCase.
Open

    public function I_can_use_different_instances_with_same_values_of_rolls_on_quality()
    {
        $firstRollOnQuality = $this->createRollOnQuality(1);
        $similarRollOnQuality = $this->createRollOnQuality(1);
        $extendedRollOnSuccess = new ExtendedRollOnSuccess(
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/ExtendedRollOnSuccessTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language