Sign upLogin

jaroslavtyc/drd-plus-tables

View on GitHub
Star
tests/Tables/Armaments/Weapons/Melee/MorningstarsAndMorgensternsTableTest.php

Summary

Maintainability
F
1 wk
Test Coverage

Method provideArmamentAndNameWithValue has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function provideArmamentAndNameWithValue(): array
    {
        return [
            [MeleeWeaponCode::LIGHT_MORGENSTERN, MeleeWeaponsTable::REQUIRED_STRENGTH, 3],
            [MeleeWeaponCode::LIGHT_MORGENSTERN, MeleeWeaponsTable::LENGTH, 2],
Severity: Major
Found in tests/Tables/Armaments/Weapons/Melee/MorningstarsAndMorgensternsTableTest.php - About 2 hrs to fix

    Avoid using static access to class '\DrdPlus\Codes\Armaments\MeleeWeaponCode' in method 'I_can_get_every_weapon_by_weapon_codes_library'.
    Open

            foreach (MeleeWeaponCode::getMorningstarsAndMorgensternsValues(false /* without custom ones */) as $morningstarAndMorgensternValue) {
    Severity: Minor
    Found in tests/Tables/Armaments/Weapons/Melee/MorningstarsAndMorgensternsTableTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    <?php declare(strict_types = 1);

namespace DrdPlus\Tests\Tables\Armaments\Weapons\Melee;

use DrdPlus\Codes\Armaments\MeleeWeaponCode;
    Severity: Major
    Found in tests/Tables/Armaments/Weapons/Melee/MorningstarsAndMorgensternsTableTest.php and 2 other locations - About 6 days to fix
    tests/Tables/Armaments/Weapons/Melee/SwordsTableTest.php on lines 1..94
    tests/Tables/Armaments/Weapons/Melee/VoulgesAndTridentsTableTest.php on lines 1..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 1190.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid excessively long variable names like $morningstarAndMorgensternValue. Keep variable name length under 20.
    Open

            foreach (MeleeWeaponCode::getMorningstarsAndMorgensternsValues(false /* without custom ones */) as $morningstarAndMorgensternValue) {
    Severity: Minor
    Found in tests/Tables/Armaments/Weapons/Melee/MorningstarsAndMorgensternsTableTest.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $morningstarsAndMorgensternsTable. Keep variable name length under 20.
    Open

            $morningstarsAndMorgensternsTable = new MorningstarsAndMorgensternsTable();
    Severity: Minor
    Found in tests/Tables/Armaments/Weapons/Melee/MorningstarsAndMorgensternsTableTest.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    The method I_can_get_every_weapon_by_weapon_codes_library is not named in camelCase.
    Open

        public function I_can_get_every_weapon_by_weapon_codes_library()
    {
        $morningstarsAndMorgensternsTable = new MorningstarsAndMorgensternsTable();
        foreach (MeleeWeaponCode::getMorningstarsAndMorgensternsValues(false /* without custom ones */) as $morningstarAndMorgensternValue) {
            $row = $morningstarsAndMorgensternsTable->getRow([$morningstarAndMorgensternValue]);
    Severity: Minor
    Found in tests/Tables/Armaments/Weapons/Melee/MorningstarsAndMorgensternsTableTest.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status