Sign upLogin

jaroslavtyc/drd-plus-therugist-spells

View on GitHub
Star
DrdPlus/Theurgist/Spells/FormulasTable.php

Summary

Maintainability
A
2 hrs
Test Coverage

Showing 7 of 7 total issues

FormulasTable has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class FormulasTable extends AbstractFileTable
{
    protected function getDataFileName(): string
    {
        return __DIR__ . '/data/formulas.csv';
Severity: Minor
Found in DrdPlus/Theurgist/Spells/FormulasTable.php - About 2 hrs to fix

    The class FormulasTable has a coupling between objects value of 22. Consider to reduce the number of dependencies under 13.
    Open

    class FormulasTable extends AbstractFileTable
    {
        protected function getDataFileName(): string
        {
            return __DIR__ . '/data/formulas.csv';
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd

    Avoid using static access to class '\DrdPlus\Codes\Theurgist\ModifierCode' in method 'getModifierCodes'.
    Open

                        return ModifierCode::getIt($modifierValue);
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd

    Avoid using static access to class '\DrdPlus\Codes\Theurgist\SpellTraitCode' in method 'getSpellTraitCodes'.
    Open

                    return SpellTraitCode::getIt($spellTraitValue);
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd

    Avoid using static access to class '\DrdPlus\Codes\Theurgist\FormCode' in method 'getForms'.
    Open

                    return FormCode::getIt($formValue);
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd

    Avoid using static access to class '\DrdPlus\Codes\Theurgist\ProfileCode' in method 'getProfiles'.
    Open

                        return ProfileCode::getIt($profileValue);
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd

    Avoid unused parameters such as '$formulaCode'.
    Open

            FormulaCode $formulaCode): CastingRounds
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd
    Category
    Status