Sign upLogin

jaroslavtyc/drd-plus-therugist-spells

View on GitHub
Star
DrdPlus/Theurgist/Spells/FormulasTable.php

Summary

Maintainability
A
2 hrs
Test Coverage

FormulasTable has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class FormulasTable extends AbstractFileTable
{
    protected function getDataFileName(): string
    {
        return __DIR__ . '/data/formulas.csv';
Severity: Minor
Found in DrdPlus/Theurgist/Spells/FormulasTable.php - About 2 hrs to fix

    The class FormulasTable has a coupling between objects value of 22. Consider to reduce the number of dependencies under 13.
    Open

    class FormulasTable extends AbstractFileTable
{
    protected function getDataFileName(): string
    {
        return __DIR__ . '/data/formulas.csv';
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Avoid using static access to class '\DrdPlus\Codes\Theurgist\ModifierCode' in method 'getModifierCodes'.
    Open

                        return ModifierCode::getIt($modifierValue);
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\Codes\Theurgist\ProfileCode' in method 'getProfiles'.
    Open

                        return ProfileCode::getIt($profileValue);
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\Codes\Theurgist\FormCode' in method 'getForms'.
    Open

                    return FormCode::getIt($formValue);
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\Codes\Theurgist\SpellTraitCode' in method 'getSpellTraitCodes'.
    Open

                    return SpellTraitCode::getIt($spellTraitValue);
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused parameters such as '$formulaCode'.
    Open

            FormulaCode $formulaCode): CastingRounds
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/FormulasTable.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    There are no issues that match your filters.

    Category
    Status