Sign upLogin

jaroslavtyc/drd-plus-therugist-spells

View on GitHub
Star

Showing 142 of 142 total issues

Modifier has 51 functions (exceeds 20 allowed). Consider refactoring.
Open

class Modifier extends StrictObject
{
    use ToFlatArrayTrait;

    /** @var ModifierCode */
Severity: Major
Found in DrdPlus/Theurgist/Spells/Modifier.php - About 7 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function __construct($difficultyAdditionByRealmsNotation, int $currentAddition = null)
    {
        $parts = $this->parseParts(ToString::toString($difficultyAdditionByRealmsNotation));
        if (\count($parts) === 1 && \array_keys($parts) === [0]) {
            $this->realmsChangePerAdditionStep = 1;
    Severity: Major
    Found in DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficultyAddition.php and 1 other location - About 6 hrs to fix
    DrdPlus/Theurgist/Spells/SpellParameters/AdditionByDifficulty.php on lines 33..49

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 213.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function __construct($additionByDifficultyNotation, int $currentAddition = null)
    {
        $parts = $this->parseParts(ToString::toString($additionByDifficultyNotation));
        if (\count($parts) === 1 && \array_keys($parts) === [0]) {
            $this->difficultyPerAdditionStep = 1;
    Severity: Major
    Found in DrdPlus/Theurgist/Spells/SpellParameters/AdditionByDifficulty.php and 1 other location - About 6 hrs to fix
    DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficultyAddition.php on lines 36..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 213.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File Formula.php has 410 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
declare(strict_types=1);

namespace DrdPlus\Theurgist\Spells;
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/Formula.php - About 5 hrs to fix

      File Modifier.php has 375 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
declare(strict_types=1);

namespace DrdPlus\Theurgist\Spells;
      Severity: Minor
      Found in DrdPlus/Theurgist/Spells/Modifier.php - About 5 hrs to fix

        Formula has 32 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Formula extends StrictObject
{
    use ToFlatArrayTrait;

    /** @var FormulaCode */
        Severity: Minor
        Found in DrdPlus/Theurgist/Spells/Formula.php - About 4 hrs to fix

          The class Formula has an overall complexity of 79 which is very high. The configured complexity threshold is 50.
          Open

          class Formula extends StrictObject
{
    use ToFlatArrayTrait;

    /** @var FormulaCode */
          Severity: Minor
          Found in DrdPlus/Theurgist/Spells/Formula.php by phpmd

          The class Modifier has an overall complexity of 74 which is very high. The configured complexity threshold is 50.
          Open

          class Modifier extends StrictObject
{
    use ToFlatArrayTrait;

    /** @var ModifierCode */
          Severity: Minor
          Found in DrdPlus/Theurgist/Spells/Modifier.php by phpmd

          File ModifiersTable.php has 303 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
declare(strict_types = 1);

namespace DrdPlus\Theurgist\Spells;
          Severity: Minor
          Found in DrdPlus/Theurgist/Spells/ModifiersTable.php - About 3 hrs to fix

            ModifiersTable has 27 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class ModifiersTable extends AbstractFileTable
{
    use ToFlatArrayTrait;

    /**
            Severity: Minor
            Found in DrdPlus/Theurgist/Spells/ModifiersTable.php - About 3 hrs to fix

              FormulasTable has 21 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class FormulasTable extends AbstractFileTable
{
    protected function getDataFileName(): string
    {
        return __DIR__ . '/data/formulas.csv';
              Severity: Minor
              Found in DrdPlus/Theurgist/Spells/FormulasTable.php - About 2 hrs to fix

                Function getParameterBonusFromModifiers has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function getParameterBonusFromModifiers(string $parameterName)
    {
        $bonusParts = [];
        foreach ($this->modifiers as $modifier) {
            if ($modifier->getModifierCode()->getValue() === ModifierCode::GATE) {
                Severity: Minor
                Found in DrdPlus/Theurgist/Spells/Formula.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid excessively long variable names like $sumOfDifficultyChange. Keep variable name length under 20.
                Open

                        $sumOfDifficultyChange = 0;
                Severity: Minor
                Found in DrdPlus/Theurgist/Spells/SpellTraitsTable.php by phpmd

                LongVariable

                Since: 0.2

                Detects when a field, formal or local variable is declared with a long name.

                Example

                class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                Source https://phpmd.org/rules/naming.html#longvariable

                Avoid excessively long class names like AdditionByDifficultyWithoutStepsCanNotBeChanged. Keep class name length under 40.
                Open

                class AdditionByDifficultyWithoutStepsCanNotBeChanged extends \LogicException implements Logic
{

}
                Severity: Minor
                Found in DrdPlus/Theurgist/Spells/SpellParameters/Exceptions/AdditionByDifficultyWithoutStepsCanNotBeChanged.php by phpmd

                LongClassName

                Since: 2.9

                Detects when classes or interfaces are declared with excessively long names.

                Example

                class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

                Source https://phpmd.org/rules/naming.html#longclassname

                Avoid excessively long class names like MinimalDifficultyCanNotBeGreaterThanMaximal. Keep class name length under 40.
                Open

                class MinimalDifficultyCanNotBeGreaterThanMaximal extends \InvalidArgumentException implements Logic
{

}
                Severity: Minor
                Found in DrdPlus/Theurgist/Spells/SpellParameters/Partials/Exceptions/MinimalDifficultyCanNotBeGreaterThanMaximal.php by phpmd

                LongClassName

                Since: 2.9

                Detects when classes or interfaces are declared with excessively long names.

                Example

                class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

                Source https://phpmd.org/rules/naming.html#longclassname

                Avoid excessively long variable names like $formulaSpellParameterValues. Keep variable name length under 20.
                Open

                        array $formulaSpellParameterValues = [],
                Severity: Minor
                Found in DrdPlus/Theurgist/Spells/Formula.php by phpmd

                LongVariable

                Since: 0.2

                Detects when a field, formal or local variable is declared with a long name.

                Example

                class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                Source https://phpmd.org/rules/naming.html#longvariable

                Avoid excessively long variable names like $difficultyAdditionPerStep. Keep variable name length under 20.
                Open

                    private $difficultyAdditionPerStep;
                Severity: Minor
                Found in DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficultyAddition.php by phpmd

                LongVariable

                Since: 0.2

                Detects when a field, formal or local variable is declared with a long name.

                Example

                class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                Source https://phpmd.org/rules/naming.html#longvariable

                Avoid excessively long variable names like $modifierRealmsAffection. Keep variable name length under 20.
                Open

                            $modifierRealmsAffection = $modifier->getRealmsAffection();
                Severity: Minor
                Found in DrdPlus/Theurgist/Spells/Formula.php by phpmd

                LongVariable

                Since: 0.2

                Detects when a field, formal or local variable is declared with a long name.

                Example

                class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                Source https://phpmd.org/rules/naming.html#longvariable

                Avoid excessively long variable names like $modifierSpellParameterValues. Keep variable name length under 20.
                Open

                        array $modifierSpellParameterValues,
                Severity: Minor
                Found in DrdPlus/Theurgist/Spells/Modifier.php by phpmd

                LongVariable

                Since: 0.2

                Detects when a field, formal or local variable is declared with a long name.

                Example

                class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                Source https://phpmd.org/rules/naming.html#longvariable

                Avoid excessively long variable names like $additionByDifficultyNotation. Keep variable name length under 20.
                Open

                    public function __construct($additionByDifficultyNotation, int $currentAddition = null)
                Severity: Minor
                Found in DrdPlus/Theurgist/Spells/SpellParameters/AdditionByDifficulty.php by phpmd

                LongVariable

                Since: 0.2

                Detects when a field, formal or local variable is declared with a long name.

                Example

                class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                Source https://phpmd.org/rules/naming.html#longvariable

                Severity
                Category
                Status
                Source
                Language