Sign upLogin

jaroslavtyc/drd-plus-therugist-spells

View on GitHub
Star
DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficulty.php

Summary

Maintainability
A
1 hr
Test Coverage

Showing 8 of 8 total issues

Method __construct has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(array $values)
    {
        try {
            $this->minimal = ToInteger::toPositiveInteger($values[0] ?? null);
        } catch (\Granam\Integer\Tools\Exceptions\Exception $exception) {
Severity: Minor
Found in DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficulty.php - About 1 hr to fix

    Avoid using static access to class '\Granam\Integer\Tools\ToInteger' in method '__construct'.
    Open

                $this->maximal = ToInteger::toPositiveInteger($values[1] ?? null);
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficulty.php by phpmd

    Avoid using static access to class '\Granam\Integer\Tools\ToInteger' in method '__construct'.
    Open

                $this->minimal = ToInteger::toPositiveInteger($values[0] ?? null);
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficulty.php by phpmd

    Avoid using static access to class '\Granam\Tools\ValueDescriber' in method '__construct'.
    Open

                    . (array_key_exists(0, $values) ? ValueDescriber::describe($values[0]) : 'nothing')
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficulty.php by phpmd

    Avoid using static access to class '\Granam\Integer\Tools\ToInteger' in method 'createWithChange'.
    Open

            $difficultyChangeValue = ToInteger::toInteger($difficultyChangeValue);
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficulty.php by phpmd

    Avoid using static access to class '\Granam\Tools\ValueDescriber' in method '__construct'.
    Open

                    . (array_key_exists(1, $values) ? ValueDescriber::describe($values[1]) : 'nothing')
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficulty.php by phpmd

    Avoid excessively long variable names like $difficultyChangeValue. Keep variable name length under 20.
    Open

        public function createWithChange($difficultyChangeValue): FormulaDifficulty
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficulty.php by phpmd

    Avoid excessively long variable names like $formulaDifficultyAddition. Keep variable name length under 20.
    Open

        private $formulaDifficultyAddition;
    Severity: Minor
    Found in DrdPlus/Theurgist/Spells/SpellParameters/FormulaDifficulty.php by phpmd
    Category
    Status