Sign upLogin

jaroslavtyc/drd-plus-therugist-spells

View on GitHub
Star

Showing 142 of 142 total issues

Avoid using static access to class '\DrdPlus\Codes\Theurgist\ModifierCode' in method 'getChildModifiers'.
Open

                    return ModifierCode::getIt($modifierValue);
Severity: Minor
Found in DrdPlus/Theurgist/Spells/ModifiersTable.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'sanitizeDifficulty'.
Open

                'Expected positive integer for difficulty increment , got ' . ValueDescriber::describe($difficultyChange)
Severity: Minor
Found in DrdPlus/Theurgist/Spells/SpellParameters/AdditionByDifficulty.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language