Sign upLogin

jaroslavtyc/granam-gpwebpay

View on GitHub
Star
GpWebPay/CardPayRequestValues.php

Summary

Maintainability
D
2 days
Test Coverage

File CardPayRequestValues.php has 495 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

namespace Granam\GpWebPay;

use Granam\Boolean\Tools\ToBoolean;
Severity: Minor
Found in GpWebPay/CardPayRequestValues.php - About 7 hrs to fix

    CardPayRequestValues has 37 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class CardPayRequestValues extends StrictObject
{

    // name => is required
    private static array $keysExpectedInArray = [
    Severity: Minor
    Found in GpWebPay/CardPayRequestValues.php - About 4 hrs to fix

      Function normalizeValues has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function normalizeValues(array $withUpperCasedKeys): array
    {
        $normalizedValues = [];
        foreach (self::$keysExpectedInArray as $key => $required) {
            if (($withUpperCasedKeys[$key] ?? null) === null) {
      Severity: Minor
      Found in GpWebPay/CardPayRequestValues.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 16 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              CurrencyCodes $currencyCodes,
        int $orderNumber,
        float $price,
        int $currencyNumericCode,
        bool $depositFlag, // false = instant payment not required, true = requires immediate payment
      Severity: Major
      Found in GpWebPay/CardPayRequestValues.php - About 2 hrs to fix

        Method sanitizeAsciiRange has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function sanitizeAsciiRange(
        string $value,
        string $nameOfParameter,
        array $characterRanges = [[' ' /* 0x20 = space */, '~' /* 0x7E = tilde */]]
    ): string
        Severity: Minor
        Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

          Method normalizeValues has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private static function normalizeValues(array $withUpperCasedKeys): array
    {
        $normalizedValues = [];
        foreach (self::$keysExpectedInArray as $key => $required) {
            if (($withUpperCasedKeys[$key] ?? null) === null) {
          Severity: Minor
          Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

            Method setPayMethods has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function setPayMethods(array $payMethods = null)
    {
        if ($payMethods === null) {
            return;
        }
            Severity: Minor
            Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

              Method createFromArray has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function createFromArray(array $valuesFromGetOrPost, CurrencyCodes $currencyCodes): CardPayRequestValues
    {
        $withUpperCasedKeys = [];
        foreach ($valuesFromGetOrPost as $key => $value) {
            $withUpperCasedKeys[\strtoupper(\trim($key))] = $value;
              Severity: Minor
              Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

                Function setPayMethods has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function setPayMethods(array $payMethods = null)
    {
        if ($payMethods === null) {
            return;
        }
                Severity: Minor
                Found in GpWebPay/CardPayRequestValues.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status