Sign upLogin

jaroslavtyc/granam-gpwebpay

View on GitHub
Star
GpWebPay/Settings.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method getCurrentRequestUrl has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getCurrentRequestUrl(): string
    {
        $protocol = 'http';
        if (!empty($_SERVER['HTTP_X_FORWARDED_PROTO'])) {
            $protocol = $_SERVER['HTTP_X_FORWARDED_PROTO'];
Severity: Minor
Found in GpWebPay/Settings.php - About 1 hr to fix

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string $baseUrlForRequest,
        string $privateKeyFile,
        string $privateKeyPassword,
        string $publicKeyFile,
        string $merchantNumber,
    Severity: Minor
    Found in GpWebPay/Settings.php - About 45 mins to fix

      Function getCurrentRequestUrl has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getCurrentRequestUrl(): string
    {
        $protocol = 'http';
        if (!empty($_SERVER['HTTP_X_FORWARDED_PROTO'])) {
            $protocol = $_SERVER['HTTP_X_FORWARDED_PROTO'];
      Severity: Minor
      Found in GpWebPay/Settings.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method createForTest has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $privateKeyFile,
        string $privateKeyPassword,
        string $publicKeyFile,
        string $merchantNumber,
        string $urlForResponse = null
      Severity: Minor
      Found in GpWebPay/Settings.php - About 35 mins to fix

        Method createForProduction has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $privateKeyFile,
        string $privateKeyPassword,
        string $publicKeyFile,
        string $merchantNumber,
        string $urlForResponse = null
        Severity: Minor
        Found in GpWebPay/Settings.php - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status