Sign upLogin

jaroslavtyc/granam-gpwebpay

View on GitHub
Star

Showing 26 of 26 total issues

Function getCurrentRequestUrl has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private function getCurrentRequestUrl(): string
    {
        $protocol = 'http';
        if (!empty($_SERVER['HTTP_X_FORWARDED_PROTO'])) {
            $protocol = $_SERVER['HTTP_X_FORWARDED_PROTO'];
Severity: Minor
Found in GpWebPay/Settings.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        int $prCode,
        int $srCode,
        string $resultText = null,
        $exceptionCode = null, // intentionally without scalar type hint
        \Exception $previousException = null
Severity: Minor
Found in GpWebPay/Exceptions/GpWebPayErrorResponse.php - About 35 mins to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            int $prCode,
        int $srCode,
        string $resultText = null,
        $exceptionCode = null, // intentionally without scalar type hint
        \Exception $previousException = null
    Severity: Minor
    Found in GpWebPay/Exceptions/GpWebPayErrorByCustomerResponse.php - About 35 mins to fix

      Method createForTest has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $privateKeyFile,
        string $privateKeyPassword,
        string $publicKeyFile,
        string $merchantNumber,
        string $urlForResponse = null
      Severity: Minor
      Found in GpWebPay/Settings.php - About 35 mins to fix

        Method createForProduction has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $privateKeyFile,
        string $privateKeyPassword,
        string $publicKeyFile,
        string $merchantNumber,
        string $urlForResponse = null
        Severity: Minor
        Found in GpWebPay/Settings.php - About 35 mins to fix

          Function setPayMethods has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function setPayMethods(array $payMethods = null)
    {
        if ($payMethods === null) {
            return;
        }
          Severity: Minor
          Found in GpWebPay/CardPayRequestValues.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language